summaryrefslogtreecommitdiff
path: root/net/sctp
diff options
context:
space:
mode:
authorJon Paul Maloy <jon.maloy@ericsson.com>2016-06-08 19:00:05 +0300
committerDavid S. Miller <davem@davemloft.net>2016-06-08 21:27:02 +0300
commit5ca509fc0b6bcfeccf03c8c4bb5e4d1a62720c03 (patch)
tree13904d6d2fc5ee71548362698378e7206dfcbdab /net/sctp
parentc4282ca76c5b81ed73ef4c5eb5c07ee397e51642 (diff)
downloadlinux-5ca509fc0b6bcfeccf03c8c4bb5e4d1a62720c03.tar.xz
tipc: change node timer unit from jiffies to ms
The node keepalive interval is recalculated at each timer expiration to catch any changes in the link tolerance, and stored in a field in struct tipc_node. We use jiffies as unit for the stored value. This is suboptimal, because it makes the calculation unnecessary complex, including two unit conversions. The conversions also lead to a rounding error that causes the link "abort limit" to be 3 in the normal case, instead of 4, as intended. This again leads to unnecessary link resets when the network is pushed close to its limit, e.g., in an environment with hundreds of nodes or namesapces. In this commit, we do instead let the keepalive value be calculated and stored in milliseconds, so that there is only one conversion and the rounding error is eliminated. We also remove a redundant "keepalive" field in struct tipc_link. This is remnant from the previous implementation. Acked-by: Ying Xue <ying.xue@windriver.com> Signed-off-by: Jon Maloy <jon.maloy@ericsson.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sctp')
0 files changed, 0 insertions, 0 deletions