summaryrefslogtreecommitdiff
path: root/mm
diff options
context:
space:
mode:
authorDaniel Borkmann <dborkman@redhat.com>2013-06-27 15:44:26 +0400
committerDavid S. Miller <davem@davemloft.net>2013-06-29 09:09:27 +0400
commit3b233fe0435518169af03027aedc83d42eb28ac4 (patch)
tree9306d51813bf8f2c3d83ce7cbc6b9455481d595f /mm
parentcf6122be45de68bc773f64e4266db76129ea556f (diff)
downloadlinux-3b233fe0435518169af03027aedc83d42eb28ac4.tar.xz
nlmon: fix comparison in nlmon_is_valid_mtu
This patch fixes the following warning introduced in e4fc408e0e99 ("packet: nlmon: virtual netlink monitoring device for packet sockets") reported by Dan Carpenter: warning: "drivers/net/nlmon.c:31 nlmon_is_valid_mtu() warn: always true condition '(new_mtu <= ((~0 >> 1))) => (s32min-s32max <= s32max)'" Thus, we should simply remove the test against INT_MAX. Next to that we also need to explicitly cast the sizeof() case as the comparison is type promoted to unsigned long so negative values are then valid instead of invalid. While at it, this also adds a comment about Netlink and MTUs. Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Daniel Borkmann <dborkman@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'mm')
0 files changed, 0 insertions, 0 deletions