diff options
author | Tahsin Erdogan <tahsin@google.com> | 2017-02-15 06:27:38 +0300 |
---|---|---|
committer | Jens Axboe <axboe@fb.com> | 2017-02-15 18:40:04 +0300 |
commit | b410aff2bd9f101bc096069612391aecce204cd1 (patch) | |
tree | 977805735b8ce122d67da721e8a960c15ef89769 /lib/bitrev.c | |
parent | 3d492c2e0146ccaad08c7cbe16e2e229328b5e79 (diff) | |
download | linux-b410aff2bd9f101bc096069612391aecce204cd1.tar.xz |
block: do not allow updates through sysfs until registration completes
When a new disk shows up, sysfs queue directory is created before elevator
is registered. This allows a user to attempt a scheduler switch even though
the initial registration hasn't completed yet.
In one scenario, blk_register_queue() calls elv_register_queue() and
right before cfq_registered_queue() is called, another process executes
elevator_switch() and replaces q->elevator with deadline scheduler. When
cfq_registered_queue() executes it interprets e->elevator_data as struct
cfq_data even though it is actually struct deadline_data.
Grab q->sysfs_lock in blk_register_queue() to synchronize with sysfs
callers.
Signed-off-by: Tahsin Erdogan <tahsin@google.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'lib/bitrev.c')
0 files changed, 0 insertions, 0 deletions