summaryrefslogtreecommitdiff
path: root/kernel/memremap.c
diff options
context:
space:
mode:
authorFlavio Leitner <fbl@redhat.com>2018-06-27 16:34:26 +0300
committerDavid S. Miller <davem@davemloft.net>2018-06-28 16:21:32 +0300
commit9c4c325252c54b34d53b3d0ffd535182b744e03d (patch)
treef692ec93f735a81396e68840004926ac8e0d7184 /kernel/memremap.c
parentf564650106a6e85702660fefd59fdff0877ab46a (diff)
downloadlinux-9c4c325252c54b34d53b3d0ffd535182b744e03d.tar.xz
skbuff: preserve sock reference when scrubbing the skb.
The sock reference is lost when scrubbing the packet and that breaks TSQ (TCP Small Queues) and XPS (Transmit Packet Steering) causing performance impacts of about 50% in a single TCP stream when crossing network namespaces. XPS breaks because the queue mapping stored in the socket is not available, so another random queue might be selected when the stack needs to transmit something like a TCP ACK, or TCP Retransmissions. That causes packet re-ordering and/or performance issues. TSQ breaks because it orphans the packet while it is still in the host, so packets are queued contributing to the buffer bloat problem. Preserving the sock reference fixes both issues. The socket is orphaned anyways in the receiving path before any relevant action and on TX side the netfilter checks if the reference is local before use it. Signed-off-by: Flavio Leitner <fbl@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'kernel/memremap.c')
0 files changed, 0 insertions, 0 deletions