diff options
| author | Andreas Gruenbacher <agruenba@redhat.com> | 2017-03-16 16:54:57 +0300 |
|---|---|---|
| committer | Bob Peterson <rpeterso@redhat.com> | 2017-03-16 16:58:49 +0300 |
| commit | 972b044eeca582ef173d063773e292bd9e8633d6 (patch) | |
| tree | 96ce685382befb17ba33751851cebde074f1a1a1 /fs/gfs2/glock.c | |
| parent | 92ecd73a887c4a2b94daf5fc35179d75d1c4ef95 (diff) | |
| download | linux-972b044eeca582ef173d063773e292bd9e8633d6.tar.xz | |
gfs2: Don't pack struct lm_lockname
As per a suggestion by Linus, don't pack struct lm_lockname: we did that
because the struct is used as a rhashtable key, but packing tells the
compiler that the 64-bit fields in the struct may be unaligned, causing
it to generate worse code on some architectures. Instead, rearrange the
fields in the struct so that there is no padding between fields, and
exclude any tail padding from the hash key size.
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Diffstat (limited to 'fs/gfs2/glock.c')
| -rw-r--r-- | fs/gfs2/glock.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c index b2638d8a2459..35f3b0a1d81b 100644 --- a/fs/gfs2/glock.c +++ b/fs/gfs2/glock.c @@ -73,7 +73,7 @@ static DEFINE_SPINLOCK(lru_lock); static struct rhashtable_params ht_parms = { .nelem_hint = GFS2_GL_HASH_SIZE * 3 / 4, - .key_len = sizeof(struct lm_lockname), + .key_len = offsetofend(struct lm_lockname, ln_type), .key_offset = offsetof(struct gfs2_glock, gl_name), .head_offset = offsetof(struct gfs2_glock, gl_node), }; |