diff options
| author | Liu Bo <bo.li.liu@oracle.com> | 2017-09-07 20:22:20 +0300 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2017-10-30 14:27:59 +0300 |
| commit | f851689b5ae3eb8e1b4d397eaf2805ccfd88bf77 (patch) | |
| tree | f03b7128699fb5449ac8b2c3b6e5a5dd0ea5cbf9 /fs/btrfs/disk-io.c | |
| parent | 8806d7185bf7a81c28ea46ce67f78669f91f0591 (diff) | |
| download | linux-f851689b5ae3eb8e1b4d397eaf2805ccfd88bf77.tar.xz | |
Btrfs: remove nr_async_bios
This was intended to congest higher layers to not send bios, but as
1) the congested bit has been taken by writeback
Async bios come from buffered writes and DIO writes.
For DIO writes, we want to submit them ASAP, while for buffered writes,
writeback uses balance_dirty_pages() to throttle how much dirty pages we
can have.
2) and no one is waiting for %nr_async_bios down to zero,
Historically, it was introduced along with changes which let
checksumming workload spread accross different cpus. And at that time,
pdflush was used instead of per-bdi flushing, perhaps pdflush did not
have the necessary information for writeback to do throttling.
We can safely remove them now.
Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
[ additional explanation from mails, removed unused variable 'limit' ]
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/disk-io.c')
| -rw-r--r-- | fs/btrfs/disk-io.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index 09407384e996..2b18b0c379c1 100644 --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c @@ -2518,7 +2518,6 @@ int open_ctree(struct super_block *sb, atomic_set(&fs_info->nr_async_submits, 0); atomic_set(&fs_info->async_delalloc_pages, 0); atomic_set(&fs_info->async_submit_draining, 0); - atomic_set(&fs_info->nr_async_bios, 0); atomic_set(&fs_info->defrag_running, 0); atomic_set(&fs_info->qgroup_op_seq, 0); atomic_set(&fs_info->reada_works_cnt, 0); |