diff options
| author | Antti Palosaari <crope@iki.fi> | 2012-01-11 03:46:26 +0400 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2012-01-11 04:58:55 +0400 |
| commit | dab734ec95168488c4b32632e968ce885a083078 (patch) | |
| tree | 2462b0f176f0d2dcc10ec93d29007db32426ff4b /drivers | |
| parent | b748e6a91e136a582943a496eac40071a23beff3 (diff) | |
| download | linux-dab734ec95168488c4b32632e968ce885a083078.tar.xz | |
[media] hd29l2: fix review findings
Fix some issues pointed out by Mauro.
Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/media/dvb/frontends/hd29l2.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/media/dvb/frontends/hd29l2.c b/drivers/media/dvb/frontends/hd29l2.c index 9959a5abb532..a00318190837 100644 --- a/drivers/media/dvb/frontends/hd29l2.c +++ b/drivers/media/dvb/frontends/hd29l2.c @@ -30,7 +30,7 @@ MODULE_PARM_DESC(debug, "Turn on/off frontend debugging (default:off)."); static int hd29l2_wr_regs(struct hd29l2_priv *priv, u8 reg, u8 *val, int len) { int ret; - u8 buf[2+len]; + u8 buf[2 + len]; struct i2c_msg msg[1] = { { .addr = priv->cfg.i2c_addr, @@ -476,7 +476,7 @@ static enum dvbfe_search hd29l2_search(struct dvb_frontend *fe) /* ensure modulation validy */ /* 0=QAM4_NR, 1=QAM4, 2=QAM16, 3=QAM32, 4=QAM64 */ - if (modulation > 4) { + if (modulation > (ARRAY_SIZE(reg_mod_vals_tab[0].val) - 1)) { dbg("%s: modulation=%d not valid", __func__, modulation); goto err; } @@ -735,7 +735,7 @@ static int hd29l2_init(struct dvb_frontend *fe) /* reset demod */ /* it is recommended to HW reset chip using RST_N pin */ if (fe->callback) { - ret = fe->callback(fe, 0, 0, 0); + ret = fe->callback(fe, DVB_FRONTEND_COMPONENT_DEMOD, 0, 0); if (ret) goto err; |