summaryrefslogtreecommitdiff
path: root/drivers/usb/gadget/udc/s3c-hsudc.c
diff options
context:
space:
mode:
authorMichal Sojka <sojka@merica.cz>2014-09-25 00:43:19 +0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2014-09-25 18:58:50 +0400
commit304f7e5e1d08fa2f5674c1323bd0ebd806c86b81 (patch)
tree0d69327f14a23a66061fc9d39dee1ec7c6b56932 /drivers/usb/gadget/udc/s3c-hsudc.c
parent3fc2aa5522ab958374d93ef5d2e12df7ee233c91 (diff)
downloadlinux-304f7e5e1d08fa2f5674c1323bd0ebd806c86b81.tar.xz
usb: gadget: Refactor request completion
Use the recently introduced usb_gadget_giveback_request() in favor of direct invocation of the completion routine. All places in drivers/usb/ matching "[-.]complete(" were replaced with a call to usb_gadget_giveback_request(). This was compile-tested with all ARM drivers enabled and runtime-tested for musb. Signed-off-by: Michal Sojka <sojka@merica.cz> Acked-by: Felipe Balbi <balbi@ti.com> Tested-by: Felipe Balbi <balbi@ti.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/gadget/udc/s3c-hsudc.c')
-rw-r--r--drivers/usb/gadget/udc/s3c-hsudc.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/usb/gadget/udc/s3c-hsudc.c b/drivers/usb/gadget/udc/s3c-hsudc.c
index 10c6a128250c..dfbf55797360 100644
--- a/drivers/usb/gadget/udc/s3c-hsudc.c
+++ b/drivers/usb/gadget/udc/s3c-hsudc.c
@@ -258,8 +258,7 @@ static void s3c_hsudc_complete_request(struct s3c_hsudc_ep *hsep,
hsep->stopped = 1;
spin_unlock(&hsudc->lock);
- if (hsreq->req.complete != NULL)
- hsreq->req.complete(&hsep->ep, &hsreq->req);
+ usb_gadget_giveback_request(&hsep->ep, &hsreq->req);
spin_lock(&hsudc->lock);
hsep->stopped = stopped;
}