diff options
| author | Miaoqian Lin <linmq006@gmail.com> | 2022-01-20 13:46:54 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-04-08 15:23:27 +0300 |
| commit | 3a4bcc4cb612e0381707582aa8ea0be7194edc63 (patch) | |
| tree | 521e469e74a5599d7320d6945bce61a30c598318 /drivers/power/reset | |
| parent | cb42b6cfc5b09cf3f6f963435732d5f3b552a050 (diff) | |
| download | linux-3a4bcc4cb612e0381707582aa8ea0be7194edc63.tar.xz | |
power: reset: gemini-poweroff: Fix IRQ check in gemini_poweroff_probe
[ Upstream commit ba18dad0fb880cd29aa97b6b75560ef14d1061ba ]
platform_get_irq() returns negative error number instead 0 on failure.
And the doc of platform_get_irq() provides a usage example:
int irq = platform_get_irq(pdev, 0);
if (irq < 0)
return irq;
Fix the check of return value to catch errors correctly.
Fixes: f7a388d6cd1c ("power: reset: Add a driver for the Gemini poweroff")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/power/reset')
| -rw-r--r-- | drivers/power/reset/gemini-poweroff.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/power/reset/gemini-poweroff.c b/drivers/power/reset/gemini-poweroff.c index 90e35c07240a..b7f7a8225f22 100644 --- a/drivers/power/reset/gemini-poweroff.c +++ b/drivers/power/reset/gemini-poweroff.c @@ -107,8 +107,8 @@ static int gemini_poweroff_probe(struct platform_device *pdev) return PTR_ERR(gpw->base); irq = platform_get_irq(pdev, 0); - if (!irq) - return -EINVAL; + if (irq < 0) + return irq; gpw->dev = dev; |