diff options
author | Dan Carpenter <error27@gmail.com> | 2010-12-07 00:44:23 +0300 |
---|---|---|
committer | Matthew Garrett <mjg@redhat.com> | 2011-01-08 01:03:45 +0300 |
commit | e1e0dacba5af2b0cd8f9043d0b937296c90bc990 (patch) | |
tree | 70a4dea5b47cf51693ea16f3a981e3444273c780 /drivers/platform/x86 | |
parent | d358cb55a4cc83c37fbaebc0e4401a573777c6ac (diff) | |
download | linux-e1e0dacba5af2b0cd8f9043d0b937296c90bc990.tar.xz |
WMI: return error if wmi_create_device() fails
The break resets the retval to 0 but we want to return an error code.
This was introduced in c64eefd48c4 "WMI: embed struct device directly
into wmi_block"
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
Acked-by: Dmitry Torokhov <dtor@mail.ru>
Diffstat (limited to 'drivers/platform/x86')
-rw-r--r-- | drivers/platform/x86/wmi.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c index b8e5383eab0c..05cc79672a8b 100644 --- a/drivers/platform/x86/wmi.c +++ b/drivers/platform/x86/wmi.c @@ -820,7 +820,7 @@ static acpi_status parse_wdg(acpi_handle handle) retval = wmi_create_device(&gblock[i], wblock, handle); if (retval) { wmi_free_devices(); - break; + goto out_free_pointer; } } |