diff options
| author | Barnabás Pőcze <pobrn@protonmail.com> | 2021-02-04 00:56:44 +0300 |
|---|---|---|
| committer | Hans de Goede <hdegoede@redhat.com> | 2021-02-04 12:21:30 +0300 |
| commit | 921f70ffe8901f98f7552194cc0458c4a145145e (patch) | |
| tree | ea405973f68aed79944a804433a78375a860168d /drivers/platform/x86 | |
| parent | 18227424549cfc1b3f7c88ec04be2c6a8ac3b887 (diff) | |
| download | linux-921f70ffe8901f98f7552194cc0458c4a145145e.tar.xz | |
Revert "platform/x86: ideapad-laptop: Switch touchpad attribute to be RO"
The touchpad can be enabled/disabled via this attribute on a Lenovo
Yoga 520-14IKB. Allow writing as it provides legitimate functionality.
This reverts commit 7f363145992cebf4ea760447f1cfdf6f81459683.
Signed-off-by: Barnabás Pőcze <pobrn@protonmail.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20210203215403.290792-24-pobrn@protonmail.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Diffstat (limited to 'drivers/platform/x86')
| -rw-r--r-- | drivers/platform/x86/ideapad-laptop.c | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c index a89588f3dc51..4cecf3b4e7df 100644 --- a/drivers/platform/x86/ideapad-laptop.c +++ b/drivers/platform/x86/ideapad-laptop.c @@ -462,10 +462,9 @@ static ssize_t touchpad_show(struct device *dev, return sysfs_emit(buf, "%d\n", !!result); } -/* Switch to RO for now: It might be revisited in the future */ -static ssize_t __maybe_unused touchpad_store(struct device *dev, - struct device_attribute *attr, - const char *buf, size_t count) +static ssize_t touchpad_store(struct device *dev, + struct device_attribute *attr, + const char *buf, size_t count) { struct ideapad_private *priv = dev_get_drvdata(dev); bool state; @@ -481,7 +480,7 @@ static ssize_t __maybe_unused touchpad_store(struct device *dev, return count; } -static DEVICE_ATTR_RO(touchpad); +static DEVICE_ATTR_RW(touchpad); static ssize_t conservation_mode_show(struct device *dev, struct device_attribute *attr, |