diff options
| author | Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com> | 2021-02-10 08:47:56 +0300 |
|---|---|---|
| committer | Christoph Hellwig <hch@lst.de> | 2021-02-10 18:38:05 +0300 |
| commit | d81d57cf1b4702b7c2fa8ce8f1d5c6961a0c20b5 (patch) | |
| tree | c6dc382e3a0d32548a86e509d33a738471cd78e9 /drivers/nvme/target/io-cmd-bdev.c | |
| parent | 3999434b6ce6fa452128c36cbb5017f0cd347615 (diff) | |
| download | linux-d81d57cf1b4702b7c2fa8ce8f1d5c6961a0c20b5.tar.xz | |
nvmet: add helper to report invalid opcode
In the NVMeOF block device backend, file backend, and passthru backend
we reject and report the commands if opcode is not handled.
Add an helper and use it in block device backend to keep the code
and error message uniform.
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers/nvme/target/io-cmd-bdev.c')
| -rw-r--r-- | drivers/nvme/target/io-cmd-bdev.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/nvme/target/io-cmd-bdev.c b/drivers/nvme/target/io-cmd-bdev.c index 23095bdfce06..105ef2b125cf 100644 --- a/drivers/nvme/target/io-cmd-bdev.c +++ b/drivers/nvme/target/io-cmd-bdev.c @@ -449,9 +449,6 @@ u16 nvmet_bdev_parse_io_cmd(struct nvmet_req *req) req->execute = nvmet_bdev_execute_write_zeroes; return 0; default: - pr_err("unhandled cmd %d on qid %d\n", cmd->common.opcode, - req->sq->qid); - req->error_loc = offsetof(struct nvme_common_command, opcode); - return NVME_SC_INVALID_OPCODE | NVME_SC_DNR; + return nvmet_report_invalid_opcode(req); } } |