diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2016-03-15 10:18:49 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2016-03-19 01:28:11 +0300 |
| commit | 977bc20cf66367a530d17696f7e1783510a115b7 (patch) | |
| tree | 8ace513e42a984a3dc1b3a4cb38d389f703feb9a /drivers/net | |
| parent | fe3a5f6c795810edb1646a840fec3c8c350c2a4e (diff) | |
| download | linux-977bc20cf66367a530d17696f7e1783510a115b7.tar.xz | |
mediatek: checking for IS_ERR() instead of NULL
of_phy_connect() returns NULL on error, it never returns error pointers.
Fixes: 656e705243fd ('net-next: mediatek: add support for MT7623 ethernet')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: John Crispin <blogic@openwrt.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/ethernet/mediatek/mtk_eth_soc.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c index 1e6c5498bba9..fd19d2d163b8 100644 --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c @@ -186,9 +186,9 @@ static int mtk_phy_connect_node(struct mtk_eth *eth, struct mtk_mac *mac, phydev = of_phy_connect(eth->netdev[mac->id], phy_node, mtk_phy_link_adjust, 0, phy_mode); - if (IS_ERR(phydev)) { + if (!phydev) { dev_err(eth->dev, "could not connect to PHY\n"); - return PTR_ERR(phydev); + return -ENODEV; } dev_info(eth->dev, |