diff options
| author | Edward Cree <ecree@solarflare.com> | 2020-03-09 21:16:24 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-03-10 03:44:05 +0300 |
| commit | 4b1bd9db078f7d5332c8601a2f5bd43cf0458fd4 (patch) | |
| tree | 025b5e6179204b4b5664678d088bd35f6bd2f97c /drivers/net/ethernet/sfc | |
| parent | 661388f9b0004421b2ecdeac17248bd92a3bb818 (diff) | |
| download | linux-4b1bd9db078f7d5332c8601a2f5bd43cf0458fd4.tar.xz | |
sfc: detach from cb_page in efx_copy_channel()
It's a resource, not a parameter, so we can't copy it into the new
channel's TX queues, otherwise aliasing will lead to resource-
management bugs if the channel is subsequently torn down without
being initialised.
Before the Fixes:-tagged commit there was a similar bug with
tsoh_page, but I'm not sure it's worth doing another fix for such
old kernels.
Fixes: e9117e5099ea ("sfc: Firmware-Assisted TSO version 2")
Suggested-by: Derek Shute <Derek.Shute@stratus.com>
Signed-off-by: Edward Cree <ecree@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/sfc')
| -rw-r--r-- | drivers/net/ethernet/sfc/efx_channels.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/ethernet/sfc/efx_channels.c b/drivers/net/ethernet/sfc/efx_channels.c index aeb5e8aa2f2a..73d4e39b5b16 100644 --- a/drivers/net/ethernet/sfc/efx_channels.c +++ b/drivers/net/ethernet/sfc/efx_channels.c @@ -583,6 +583,7 @@ struct efx_channel *efx_copy_channel(const struct efx_channel *old_channel) if (tx_queue->channel) tx_queue->channel = channel; tx_queue->buffer = NULL; + tx_queue->cb_page = NULL; memset(&tx_queue->txd, 0, sizeof(tx_queue->txd)); } |