diff options
| author | Arnd Bergmann <arnd@arndb.de> | 2018-02-23 16:15:32 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-02-26 19:33:02 +0300 |
| commit | ed2da6270ed9ea37d39e9ab597fc5b3b4215ae2a (patch) | |
| tree | e94c9ff12e64271f1ddd10feca2ba2f505780b12 /drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c | |
| parent | b89c7695b14f58686ac89d5add861f1f6d3fd4da (diff) | |
| download | linux-ed2da6270ed9ea37d39e9ab597fc5b3b4215ae2a.tar.xz | |
mlxsw: spectrum_kvdl: avoid uninitialized variable warning
gcc warns that 'resource_id' is not initialized if we don't come though
any of the three 'case' statements before:
drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c: In function 'mlxsw_sp_kvdl_part_init':
drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c:275:8: error: 'resource_id' may be used uninitialized in this function [-Werror=maybe-uninitialized]
In the current code, that won't happen, but it's more robust to explicitly
handle this by returning a failure from mlxsw_sp_kvdl_part_init.
Fixes: 887839e6960d ("mlxsw: spectrum_kvdl: Add support for dynamic partition set")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Arkadi Sharshevsky <arkadis@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c')
| -rw-r--r-- | drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c index 6fd701db90c9..059eb3214328 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c @@ -270,6 +270,8 @@ static int mlxsw_sp_kvdl_part_init(struct mlxsw_sp *mlxsw_sp, case MLXSW_SP_KVDL_PART_LARGE_CHUNKS: resource_id = MLXSW_SP_RESOURCE_KVD_LINEAR_LARGE_CHUNKS; break; + default: + return -EINVAL; } err = devlink_resource_size_get(devlink, resource_id, &resource_size); |