diff options
| author | Huazhong Tan <tanhuazhong@huawei.com> | 2020-01-21 11:42:13 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-01-21 13:46:21 +0300 |
| commit | 60df7e91cc3efa141802dffad3a82b95c2ec479e (patch) | |
| tree | 2d10b3addf8e04c473b0abf2947475d275028d03 /drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c | |
| parent | 322cb97c0734555d7a10299954624363de370c9c (diff) | |
| download | linux-60df7e91cc3efa141802dffad3a82b95c2ec479e.tar.xz | |
net: hns3: cleanup some coding style issue
This patch removes some unnecessary return value assignments,
some duplicated printing in the caller, refines the judgment
of 0 and uses le16_to_cpu to replace __le16_to_cpu.
Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c')
| -rw-r--r-- | drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c index f8127d72d645..c85b72dc44d2 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c @@ -1898,10 +1898,8 @@ static int hclge_handle_all_hw_msix_error(struct hclge_dev *hdev, bd_num = max_t(u32, mpf_bd_num, pf_bd_num); desc = kcalloc(bd_num, sizeof(struct hclge_desc), GFP_KERNEL); - if (!desc) { - ret = -ENOMEM; - goto out; - } + if (!desc) + return -ENOMEM; ret = hclge_handle_mpf_msix_error(hdev, desc, mpf_bd_num, reset_requests); |