diff options
| author | Antti Palosaari <crope@iki.fi> | 2014-12-17 14:16:10 +0300 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@osg.samsung.com> | 2015-02-03 21:21:48 +0300 |
| commit | 6a53fa2350f724ca84b0a1946f3046855e1efd41 (patch) | |
| tree | 2ecb4b969006f871392f74719524037b35d6d85a /drivers/media | |
| parent | a6f62431a0c166c171b6b7a62d6cad79fbbdc5da (diff) | |
| download | linux-6a53fa2350f724ca84b0a1946f3046855e1efd41.tar.xz | |
[media] rtl28xxu: do not refcount rtl2832_sdr module
This driver, rtl28xxu, offers frontend service for rtl2832_sdr
module, thus we are producer and rtl2832_sdr module is consumer.
Due to that, reference counting should be done in way rtl2832_sdr
takes refrence to rtl28xxu. Remove wrong refcount.
Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Diffstat (limited to 'drivers/media')
| -rw-r--r-- | drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 10 |
1 files changed, 2 insertions, 8 deletions
diff --git a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c index f4750189e948..27cf3419d4f1 100644 --- a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c +++ b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c @@ -1142,16 +1142,12 @@ static int rtl2832u_tuner_attach(struct dvb_usb_adapter *adap) pdata.v4l2_subdev = subdev; request_module("%s", "rtl2832_sdr"); - pdev = platform_device_register_data(&priv->i2c_client_demod->dev, + pdev = platform_device_register_data(&d->intf->dev, "rtl2832_sdr", PLATFORM_DEVID_AUTO, &pdata, sizeof(pdata)); if (pdev == NULL || pdev->dev.driver == NULL) break; - if (!try_module_get(pdev->dev.driver->owner)) { - platform_device_unregister(pdev); - break; - } priv->platform_device_sdr = pdev; break; default: @@ -1175,10 +1171,8 @@ static int rtl2832u_tuner_detach(struct dvb_usb_adapter *adap) /* remove platform SDR */ pdev = priv->platform_device_sdr; - if (pdev) { - module_put(pdev->dev.driver->owner); + if (pdev) platform_device_unregister(pdev); - } /* remove I2C tuner */ client = priv->i2c_client_tuner; |