diff options
| author | Xiyu Yang <xiyuyang19@fudan.edu.cn> | 2021-06-10 05:54:29 +0300 |
|---|---|---|
| committer | Will Deacon <will@kernel.org> | 2021-06-11 13:39:01 +0300 |
| commit | 1adf30f198c26539a62d761e45af72cde570413d (patch) | |
| tree | 79f9f55df3f09c1a0a70bc6cac637b43d9ad4aae /drivers/iommu/arm/arm-smmu/arm-smmu.c | |
| parent | 22c2d71891558170ed6d1a6bfe08caba254eafc6 (diff) | |
| download | linux-1adf30f198c26539a62d761e45af72cde570413d.tar.xz | |
iommu/arm-smmu: Fix arm_smmu_device refcount leak when arm_smmu_rpm_get fails
arm_smmu_rpm_get() invokes pm_runtime_get_sync(), which increases the
refcount of the "smmu" even though the return value is less than 0.
The reference counting issue happens in some error handling paths of
arm_smmu_rpm_get() in its caller functions. When arm_smmu_rpm_get()
fails, the caller functions forget to decrease the refcount of "smmu"
increased by arm_smmu_rpm_get(), causing a refcount leak.
Fix this issue by calling pm_runtime_resume_and_get() instead of
pm_runtime_get_sync() in arm_smmu_rpm_get(), which can keep the refcount
balanced in case of failure.
Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn>
Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
Link: https://lore.kernel.org/r/1623293672-17954-1-git-send-email-xiyuyang19@fudan.edu.cn
Signed-off-by: Will Deacon <will@kernel.org>
Diffstat (limited to 'drivers/iommu/arm/arm-smmu/arm-smmu.c')
| -rw-r--r-- | drivers/iommu/arm/arm-smmu/arm-smmu.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu.c b/drivers/iommu/arm/arm-smmu/arm-smmu.c index 88a3023676ce..5de5cf5fcc50 100644 --- a/drivers/iommu/arm/arm-smmu/arm-smmu.c +++ b/drivers/iommu/arm/arm-smmu/arm-smmu.c @@ -74,7 +74,7 @@ static bool using_legacy_binding, using_generic_binding; static inline int arm_smmu_rpm_get(struct arm_smmu_device *smmu) { if (pm_runtime_enabled(smmu->dev)) - return pm_runtime_get_sync(smmu->dev); + return pm_runtime_resume_and_get(smmu->dev); return 0; } |