diff options
| author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2020-02-12 02:42:37 +0300 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2020-03-09 06:35:46 +0300 |
| commit | afde6416e196363e49b85bb129b4c530c9d1b046 (patch) | |
| tree | fcde14a24110313b8f0be2394175be9c0b0c648e /drivers/hwmon/ibmaem.c | |
| parent | 4d52b28ddfaede27e62abe10d7ce1a6803a1334d (diff) | |
| download | linux-afde6416e196363e49b85bb129b4c530c9d1b046.tar.xz | |
hwmon: (ibmaem) Replace zero-length array with flexible-array member
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:
struct foo {
int stuff;
struct boo array[];
};
By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertenly introduced[3] to the codebase from now on.
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Link: https://lore.kernel.org/r/20200211234237.GA26971@embeddedor
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon/ibmaem.c')
| -rw-r--r-- | drivers/hwmon/ibmaem.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/ibmaem.c b/drivers/hwmon/ibmaem.c index d05ab713566d..a4ec85207782 100644 --- a/drivers/hwmon/ibmaem.c +++ b/drivers/hwmon/ibmaem.c @@ -219,7 +219,7 @@ struct aem_read_sensor_req { struct aem_read_sensor_resp { struct aem_iana_id id; - u8 bytes[0]; + u8 bytes[]; } __packed; /* Data structures to talk to the IPMI layer */ |