diff options
| author | Vinod Koul <vkoul@kernel.org> | 2019-04-26 20:00:27 +0300 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2019-04-29 07:29:07 +0300 |
| commit | c6504be53972cd57326196eb2a18b2b182c26c5c (patch) | |
| tree | 3311b7000b09a02812045565fa3786cd02e72440 /drivers/dma | |
| parent | f4fd2ec08f17b34f1c7c18414d5fc882efd51e83 (diff) | |
| download | linux-c6504be53972cd57326196eb2a18b2b182c26c5c.tar.xz | |
dmaengine: stm32-dma: Fix unsigned variable compared with zero
Commit f4fd2ec08f17: ("dmaengine: stm32-dma: use platform_get_irq()") used
unsigned variable irq to store the results and check later for negative
errors, so update the code to use signed variable for this
Fixes: f4fd2ec08f17 ("dmaengine: stm32-dma: use platform_get_irq()")
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma')
| -rw-r--r-- | drivers/dma/stm32-dma.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/dma/stm32-dma.c b/drivers/dma/stm32-dma.c index 33068185c0fe..dde796686736 100644 --- a/drivers/dma/stm32-dma.c +++ b/drivers/dma/stm32-dma.c @@ -1303,13 +1303,15 @@ static int stm32_dma_probe(struct platform_device *pdev) for (i = 0; i < STM32_DMA_MAX_CHANNELS; i++) { chan = &dmadev->chan[i]; chan->irq = platform_get_irq(pdev, i); - if (chan->irq < 0) { - ret = chan->irq; + ret = platform_get_irq(pdev, i); + if (ret < 0) { if (ret != -EPROBE_DEFER) dev_err(&pdev->dev, "No irq resource for chan %d\n", i); goto err_unregister; } + chan->irq = ret; + ret = devm_request_irq(&pdev->dev, chan->irq, stm32_dma_chan_irq, 0, dev_name(chan2dev(chan)), chan); |