diff options
author | Fabrice Gasnier <fabrice.gasnier@foss.st.com> | 2022-02-16 11:12:15 +0300 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-03-02 13:48:05 +0300 |
commit | 943a914d3dab545c1496298a193a49130213806b (patch) | |
tree | 4fb66ff7951c20e754f979d77faebd98cbcdaf60 /drivers/connector | |
parent | 85171fbf714c6b9cfa7298bc3c7ff991c91e2299 (diff) | |
download | linux-943a914d3dab545c1496298a193a49130213806b.tar.xz |
usb: dwc2: drd: fix soft connect when gadget is unconfigured
commit 32fde84362c40961726a5c91f35ad37355ccc0c6 upstream.
When the gadget driver hasn't been (yet) configured, and the cable is
connected to a HOST, the SFTDISCON gets cleared unconditionally, so the
HOST tries to enumerate it.
At the host side, this can result in a stuck USB port or worse. When
getting lucky, some dmesg can be observed at the host side:
new high-speed USB device number ...
device descriptor read/64, error -110
Fix it in drd, by checking the enabled flag before calling
dwc2_hsotg_core_connect(). It will be called later, once configured,
by the normal flow:
- udc_bind_to_driver
- usb_gadget_connect
- dwc2_hsotg_pullup
- dwc2_hsotg_core_connect
Fixes: 17f934024e84 ("usb: dwc2: override PHY input signals with usb role switch support")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Link: https://lore.kernel.org/r/1644999135-13478-1-git-send-email-fabrice.gasnier@foss.st.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/connector')
0 files changed, 0 insertions, 0 deletions