diff options
| author | Wei Yongjun <yongjun_wei@trendmicro.com.cn> | 2012-10-23 09:24:09 +0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-10-25 02:52:29 +0400 |
| commit | 1b3c16556a386fa019c48783f0f615fb416cb53b (patch) | |
| tree | f998539609df654f6593d43f6054af06a589955e /drivers/char/pc8736x_gpio.c | |
| parent | 12b9f8a20d6596c8ea7786532a4a55dacf71020c (diff) | |
| download | linux-1b3c16556a386fa019c48783f0f615fb416cb53b.tar.xz | |
pc8736x_gpio: use platform_device_unregister in pc8736x_gpio_cleanup()
platform_device_unregister() only calls platform_device_del() and
platform_device_put(), thus use platform_device_unregister() to
simplify the code.
Also the documents in platform.c shows that platform_device_del
and platform_device_put must _only_ be externally called in error
cases. All other usage is a bug.
dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/char/pc8736x_gpio.c')
| -rw-r--r-- | drivers/char/pc8736x_gpio.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/char/pc8736x_gpio.c b/drivers/char/pc8736x_gpio.c index b304ec052501..3f79a9fb6b1b 100644 --- a/drivers/char/pc8736x_gpio.c +++ b/drivers/char/pc8736x_gpio.c @@ -345,8 +345,7 @@ static void __exit pc8736x_gpio_cleanup(void) unregister_chrdev_region(MKDEV(major,0), PC8736X_GPIO_CT); release_region(pc8736x_gpio_base, PC8736X_GPIO_RANGE); - platform_device_del(pdev); - platform_device_put(pdev); + platform_device_unregister(pdev); } module_init(pc8736x_gpio_init); |