diff options
author | Geert Uytterhoeven <geert+renesas@glider.be> | 2018-07-20 19:16:59 +0300 |
---|---|---|
committer | Joerg Roedel <jroedel@suse.de> | 2018-07-27 10:41:24 +0300 |
commit | 46583e8c48c5a094ba28060615b3a7c8c576690f (patch) | |
tree | 6d21abb0e49100538d36c40895e3d43bd9c904ac /Documentation | |
parent | 2ae86955703e9e6a119af4bbe27f6b6dd7a43131 (diff) | |
download | linux-46583e8c48c5a094ba28060615b3a7c8c576690f.tar.xz |
iommu/ipmmu-vmsa: Fix allocation in atomic context
When attaching a device to an IOMMU group with
CONFIG_DEBUG_ATOMIC_SLEEP=y:
BUG: sleeping function called from invalid context at mm/slab.h:421
in_atomic(): 1, irqs_disabled(): 128, pid: 61, name: kworker/1:1
...
Call trace:
...
arm_lpae_alloc_pgtable+0x114/0x184
arm_64_lpae_alloc_pgtable_s1+0x2c/0x128
arm_32_lpae_alloc_pgtable_s1+0x40/0x6c
alloc_io_pgtable_ops+0x60/0x88
ipmmu_attach_device+0x140/0x334
ipmmu_attach_device() takes a spinlock, while arm_lpae_alloc_pgtable()
allocates memory using GFP_KERNEL. Originally, the ipmmu-vmsa driver
had its own custom page table allocation implementation using
GFP_ATOMIC, hence the spinlock was fine.
Fix this by replacing the spinlock by a mutex, like the arm-smmu driver
does.
Fixes: f20ed39f53145e45 ("iommu/ipmmu-vmsa: Use the ARM LPAE page table allocator")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Diffstat (limited to 'Documentation')
0 files changed, 0 insertions, 0 deletions