diff options
| author | Lars Poeschel <poeschel@lemonage.de> | 2020-11-09 12:31:54 +0300 |
|---|---|---|
| committer | Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> | 2020-11-09 16:06:27 +0300 |
| commit | ffdf726db7fb02a96396dcb8deb7436b4a47dd14 (patch) | |
| tree | e163c448688bc621f853563955cdc8b0b57a8511 | |
| parent | 8c9108d014c5bd0f0da2e3544eb45dc56a6da92b (diff) | |
| download | linux-ffdf726db7fb02a96396dcb8deb7436b4a47dd14.tar.xz | |
auxdisplay: hd44780_common: Fix build error
When building the hd44780_common driver without a driver that actually
uses it like panel or hd44780 you get a build error, because
hd44780_common uses charlcd, but did not select it. Its users did
select it.
This is fixed now. hd4478_common now selects charlcd in Kconfig and
panel and hd44780 do not. They only select hd44780_common.
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Lars Poeschel <poeschel@lemonage.de>
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
| -rw-r--r-- | drivers/auxdisplay/Kconfig | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig index a69623124a26..a2b59b84bb88 100644 --- a/drivers/auxdisplay/Kconfig +++ b/drivers/auxdisplay/Kconfig @@ -27,6 +27,7 @@ config CHARLCD config HD44780_COMMON tristate "Common functions for HD44780 (and compatibles) LCD displays" if COMPILE_TEST + select CHARLCD help This is a module with the common symbols for HD44780 (and compatibles) displays. This is the code that multiple other modules use. It is not @@ -37,7 +38,6 @@ config HD44780_COMMON config HD44780 tristate "HD44780 Character LCD support" depends on GPIOLIB || COMPILE_TEST - select CHARLCD select HD44780_COMMON help Enable support for Character LCDs using a HD44780 controller. @@ -196,7 +196,6 @@ config ARM_CHARLCD menuconfig PARPORT_PANEL tristate "Parallel port LCD/Keypad Panel support" depends on PARPORT - select CHARLCD select HD44780_COMMON help Say Y here if you have an HD44780 or KS-0074 LCD connected to your |