diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2018-06-19 15:25:30 +0300 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2018-08-07 22:15:41 +0300 |
| commit | ff361fda55fda55031252aca1f8afef735fe057c (patch) | |
| tree | 20d7b706d4b85ff6b5ee45c90b82c107e1f2d52e | |
| parent | 1236568ee3cbb0d3ac62d0074a29b97ecf34cbbc (diff) | |
| download | linux-ff361fda55fda55031252aca1f8afef735fe057c.tar.xz | |
cifs: Silence uninitialized variable warning
This is not really a runtime issue but Smatch complains that:
fs/cifs/smb2ops.c:1740 smb2_query_symlink()
error: uninitialized symbol 'resp_buftype'.
The warning is right that it can be uninitialized... Also "err_buf"
would be NULL at this point and we're not supposed to pass NULLs to
free_rsp_buf() or it might trigger some extra output if we turn on
debugging.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Paulo Alcantara <palcantara@suse.de>
Signed-off-by: Steve French <stfrench@microsoft.com>
| -rw-r--r-- | fs/cifs/smb2ops.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c index ea92a38b2f08..ae64cbef5e07 100644 --- a/fs/cifs/smb2ops.c +++ b/fs/cifs/smb2ops.c @@ -1700,7 +1700,7 @@ smb2_query_symlink(const unsigned int xid, struct cifs_tcon *tcon, &resp_buftype); if (!rc || !err_iov.iov_base) { rc = -ENOENT; - goto querty_exit; + goto free_path; } err_buf = err_iov.iov_base; @@ -1741,6 +1741,7 @@ smb2_query_symlink(const unsigned int xid, struct cifs_tcon *tcon, querty_exit: free_rsp_buf(resp_buftype, err_buf); + free_path: kfree(utf16_path); return rc; } |