diff options
| author | Pavel Emelyanov <xemul@openvz.org> | 2008-07-25 12:46:55 +0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-07-25 21:53:35 +0400 |
| commit | f2992db2a4f7ae10f61d5bc68c7c1528cec639e2 (patch) | |
| tree | a21366b27d11dbaef7aa810d50a935ef08538813 | |
| parent | 7e9abd89cbdf9b73d327d8173343abce9022609b (diff) | |
| download | linux-f2992db2a4f7ae10f61d5bc68c7c1528cec639e2.tar.xz | |
Mark res_counter_charge(_locked) with __must_check
Ignoring their return values may result in counter underflow in the future -
when the value charged will be uncharged (or in "leaks" - when the value is
not uncharged).
This also prevents from using charging routines to decrement the
counter value (i.e. uncharge it) ;)
(Current code works OK with res_counter, however :) )
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Cc: Balbir Singh <balbir@linux.vnet.ibm.com>
Cc: Paul Menage <menage@google.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rw-r--r-- | include/linux/res_counter.h | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/include/linux/res_counter.h b/include/linux/res_counter.h index 6d9e1fca098c..125660e7793f 100644 --- a/include/linux/res_counter.h +++ b/include/linux/res_counter.h @@ -95,8 +95,10 @@ void res_counter_init(struct res_counter *counter); * counter->limit _locked call expects the counter->lock to be taken */ -int res_counter_charge_locked(struct res_counter *counter, unsigned long val); -int res_counter_charge(struct res_counter *counter, unsigned long val); +int __must_check res_counter_charge_locked(struct res_counter *counter, + unsigned long val); +int __must_check res_counter_charge(struct res_counter *counter, + unsigned long val); /* * uncharge - tell that some portion of the resource is released |