diff options
| author | Roland Dreier <roland@purestorage.com> | 2018-01-12 00:38:00 +0300 |
|---|---|---|
| committer | Christoph Hellwig <hch@lst.de> | 2018-01-15 19:09:31 +0300 |
| commit | df351ef73789345b4b6c00434c5fd1fca7175643 (patch) | |
| tree | b6564018f48115e5489dd9066f266cbd3b70444a | |
| parent | 8adb8c147b2f6383a1676325c27e3dbc29d2fba7 (diff) | |
| download | linux-df351ef73789345b4b6c00434c5fd1fca7175643.tar.xz | |
nvme-fabrics: fix memory leak when parsing host ID option
We use match_strdup() to get a copy of the option string for host ID string, but
we just pass it to uuid_parse() and don't store the string pointer, so we need to
kfree() the string after parsing it.
Signed-off-by: Roland Dreier <roland@purestorage.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Christoph Hellwig <hch@lst.de>
| -rw-r--r-- | drivers/nvme/host/fabrics.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c index 2f68befd31bf..eb46967bb0d5 100644 --- a/drivers/nvme/host/fabrics.c +++ b/drivers/nvme/host/fabrics.c @@ -738,7 +738,9 @@ static int nvmf_parse_options(struct nvmf_ctrl_options *opts, ret = -ENOMEM; goto out; } - if (uuid_parse(p, &hostid)) { + ret = uuid_parse(p, &hostid); + kfree(p); + if (ret) { pr_err("Invalid hostid %s\n", p); ret = -EINVAL; goto out; |