diff options
| author | Taehee Yoo <ap420073@gmail.com> | 2020-03-08 04:19:17 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-03-09 07:22:29 +0300 |
| commit | c46a49a45c865350d6051df555034b86a2ac72ff (patch) | |
| tree | 05348d98bc927d62343d8d4fce7d49fe6c5b98f7 | |
| parent | eea45da4036d6d2dc3b7d2f870a0892b72aeeba4 (diff) | |
| download | linux-c46a49a45c865350d6051df555034b86a2ac72ff.tar.xz | |
bareudp: print error message when command fails
When bareudp netlink command fails, it doesn't print any error message.
So, users couldn't know the exact reason.
In order to tell the exact reason to the user, the extack error message
is used in this patch.
Signed-off-by: Taehee Yoo <ap420073@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/bareudp.c | 13 |
1 files changed, 10 insertions, 3 deletions
diff --git a/drivers/net/bareudp.c b/drivers/net/bareudp.c index b1210b516137..c9d0d68467f7 100644 --- a/drivers/net/bareudp.c +++ b/drivers/net/bareudp.c @@ -556,10 +556,17 @@ static int bareudp_validate(struct nlattr *tb[], struct nlattr *data[], return 0; } -static int bareudp2info(struct nlattr *data[], struct bareudp_conf *conf) +static int bareudp2info(struct nlattr *data[], struct bareudp_conf *conf, + struct netlink_ext_ack *extack) { - if (!data[IFLA_BAREUDP_PORT] || !data[IFLA_BAREUDP_ETHERTYPE]) + if (!data[IFLA_BAREUDP_PORT]) { + NL_SET_ERR_MSG(extack, "port not specified"); return -EINVAL; + } + if (!data[IFLA_BAREUDP_ETHERTYPE]) { + NL_SET_ERR_MSG(extack, "ethertype not specified"); + return -EINVAL; + } if (data[IFLA_BAREUDP_PORT]) conf->port = nla_get_u16(data[IFLA_BAREUDP_PORT]); @@ -635,7 +642,7 @@ static int bareudp_newlink(struct net *net, struct net_device *dev, struct bareudp_conf conf; int err; - err = bareudp2info(data, &conf); + err = bareudp2info(data, &conf, extack); if (err) return err; |