summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCan Guo <cang@codeaurora.org>2020-05-28 05:24:42 +0300
committerMartin K. Petersen <martin.petersen@oracle.com>2020-06-03 04:44:53 +0300
commitbe32acff43800c87dc5c707f5d47cc607b76b653 (patch)
tree9c765b854aac692dad2b63cacabd19bc888323eb
parent89523cb8a67cea2642deb19042a15fdd8c4138d4 (diff)
downloadlinux-be32acff43800c87dc5c707f5d47cc607b76b653.tar.xz
scsi: ufs: Don't update urgent bkops level when toggling auto bkops
Urgent bkops level is used to compare against actual bkops status read from UFS device. Urgent bkops level is set during initialization and might be updated in exception event handler during runtime. But it should not be updated to the actual bkops status every time when auto bkops is toggled. Otherwise, if urgent bkops level is updated to 0, auto bkops shall always be kept enabled. Link: https://lore.kernel.org/r/1590632686-17866-1-git-send-email-cang@codeaurora.org Fixes: 24366c2afbb0 ("scsi: ufs: Recheck bkops level if bkops is disabled") Reviewed-by: Stanley Chu <stanley.chu@mediatek.com> Signed-off-by: Can Guo <cang@codeaurora.org> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
-rw-r--r--drivers/scsi/ufs/ufshcd.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 5db18f444ea9..2bdee9edec0d 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -5123,7 +5123,6 @@ static int ufshcd_bkops_ctrl(struct ufs_hba *hba,
err = ufshcd_enable_auto_bkops(hba);
else
err = ufshcd_disable_auto_bkops(hba);
- hba->urgent_bkops_lvl = curr_status;
out:
return err;
}