summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2017-09-29 17:01:16 +0300
committerDavid S. Miller <davem@davemloft.net>2017-10-01 06:08:00 +0300
commitb1c49d14200dae47544f7ea6ee9040ded01f8425 (patch)
treed4fe30350d8cbe74e5597ca2ba21a61425d3a392
parentef739d8aabaa26dd99f5661e38a86f4d85d8dfed (diff)
downloadlinux-b1c49d14200dae47544f7ea6ee9040ded01f8425.tar.xz
net_sched: remove redundant assignment to ret
The assignment of -EINVAL to variable ret is redundant as it is being overwritten on the following error exit paths or to the return value from the following call to basic_set_parms. Fix this up by removing it. Cleans up clang warning message: net/sched/cls_basic.c:185:2: warning: Value stored to 'err' is never read Fixes: 1d8134fea2eb ("net_sched: use idr to allocate basic filter handles") Signed-off-by: Colin Ian King <colin.king@canonical.com> Acked-by: Cong Wang <xiyou.wangcong@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/sched/cls_basic.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/net/sched/cls_basic.c b/net/sched/cls_basic.c
index cfeb6f158566..700b345b07f9 100644
--- a/net/sched/cls_basic.c
+++ b/net/sched/cls_basic.c
@@ -182,7 +182,6 @@ static int basic_change(struct net *net, struct sk_buff *in_skb,
if (err < 0)
goto errout;
- err = -EINVAL;
if (handle) {
fnew->handle = handle;
if (!fold) {