diff options
| author | Kristian H. Kristensen <hoegsberg@gmail.com> | 2019-03-20 20:09:09 +0300 |
|---|---|---|
| committer | Rob Clark <robdclark@chromium.org> | 2019-04-19 21:50:06 +0300 |
| commit | 8ea274accda92d36bd510a3272adf745c6376d3f (patch) | |
| tree | ef5d3a8337be1d1963cd23d26575d33a0bf84178 | |
| parent | 48e7f18392c66f9b69ebac11c54f1a2e033ced54 (diff) | |
| download | linux-8ea274accda92d36bd510a3272adf745c6376d3f.tar.xz | |
drm/msm: Stop dropping struct_mutex in recover_worker()
Now that we don't have the mmap_sem lock inversion, we don't need to
jump through this particular hoop anymore.
Signed-off-by: Kristian H. Kristensen <hoegsberg@chromium.org>
Signed-off-by: Rob Clark <robdclark@chromium.org>
| -rw-r--r-- | drivers/gpu/drm/msm/msm_gpu.c | 13 |
1 files changed, 0 insertions, 13 deletions
diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c index 2b76657badd5..bf4ee2766431 100644 --- a/drivers/gpu/drm/msm/msm_gpu.c +++ b/drivers/gpu/drm/msm/msm_gpu.c @@ -450,21 +450,8 @@ static void recover_worker(struct work_struct *work) task = get_pid_task(submit->pid, PIDTYPE_PID); if (task) { comm = kstrdup(task->comm, GFP_KERNEL); - - /* - * So slightly annoying, in other paths like - * mmap'ing gem buffers, mmap_sem is acquired - * before struct_mutex, which means we can't - * hold struct_mutex across the call to - * get_cmdline(). But submits are retired - * from the same in-order workqueue, so we can - * safely drop the lock here without worrying - * about the submit going away. - */ - mutex_unlock(&dev->struct_mutex); cmd = kstrdup_quotable_cmdline(task, GFP_KERNEL); put_task_struct(task); - mutex_lock(&dev->struct_mutex); } if (comm && cmd) { |