summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarkus Elfring <elfring@users.sourceforge.net>2015-02-05 13:48:26 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2015-03-25 15:52:35 +0300
commit5f0163a5ee9cc7c59751768bdfd94a73186debba (patch)
tree83c4790ac312bb3857d5a96930e556f093f5cf53
parent7ca7ec40f42a13c6966fb3a5d8713e895d58c728 (diff)
downloadlinux-5f0163a5ee9cc7c59751768bdfd94a73186debba.tar.xz
driver core: Delete an unnecessary check before the function call "put_device"
The put_device() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/base/core.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/base/core.c b/drivers/base/core.c
index 07304a3b9ee2..e0998b6b6c49 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -1095,8 +1095,7 @@ done:
kobject_del(&dev->kobj);
Error:
cleanup_device_parent(dev);
- if (parent)
- put_device(parent);
+ put_device(parent);
name_error:
kfree(dev->p);
dev->p = NULL;