summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBert Kenward <bkenward@solarflare.com>2017-05-12 19:18:50 +0300
committerDavid S. Miller <davem@davemloft.net>2017-05-12 19:22:53 +0300
commit42e6cae1b35b186650f5abc7b24c20ab6986c5a0 (patch)
treef350fe9f52b5c2550207d2904d16443370d80d14
parentb12ca80ca145cecadf841ba27cc061c510cd97ca (diff)
downloadlinux-42e6cae1b35b186650f5abc7b24c20ab6986c5a0.tar.xz
sfc: revert changes to NIC revision numbers
The revision enum values (eg EFX_REV_HUNT_A0) form part of our API, and are included in ethtool. If these are inconsistent then ethtool will print garbage for a register dump (ethtool -d). Fixes: 5a6681e22c14 ("sfc: separate out SFC4000 ("Falcon") support into new sfc-falcon driver") Signed-off-by: Edward Cree <ecree@solarflare.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/ethernet/sfc/nic.h8
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/net/ethernet/sfc/nic.h b/drivers/net/ethernet/sfc/nic.h
index 7b916aa21bde..4d7fb8af880d 100644
--- a/drivers/net/ethernet/sfc/nic.h
+++ b/drivers/net/ethernet/sfc/nic.h
@@ -18,8 +18,12 @@
#include "mcdi.h"
enum {
- EFX_REV_SIENA_A0 = 0,
- EFX_REV_HUNT_A0 = 1,
+ /* Revisions 0-2 were Falcon A0, A1 and B0 respectively.
+ * They are not supported by this driver but these revision numbers
+ * form part of the ethtool API for register dumping.
+ */
+ EFX_REV_SIENA_A0 = 3,
+ EFX_REV_HUNT_A0 = 4,
};
static inline int efx_nic_rev(struct efx_nic *efx)