diff options
| author | David Ahern <dsahern@gmail.com> | 2018-08-30 02:53:27 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-09-01 09:04:03 +0300 |
| commit | 066b1030088986e61326938d5b7694e72ff693f8 (patch) | |
| tree | 70d8d2158d0f1d0d95324f9784526c4c1debd962 | |
| parent | 7788174e8726c309d8bfd8aeca743cefd6943616 (diff) | |
| download | linux-066b1030088986e61326938d5b7694e72ff693f8.tar.xz | |
net/ipv4: Add extack message that dev is required for ONLINK
Make IPv4 consistent with IPv6 and return an extack message that the
ONLINK flag requires a nexthop device.
Signed-off-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/ipv4/fib_semantics.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c index f3c89ccf14c5..bee8db979195 100644 --- a/net/ipv4/fib_semantics.c +++ b/net/ipv4/fib_semantics.c @@ -797,8 +797,10 @@ static int fib_check_nh(struct fib_config *cfg, struct fib_nh *nh, return -EINVAL; } dev = __dev_get_by_index(net, nh->nh_oif); - if (!dev) + if (!dev) { + NL_SET_ERR_MSG(extack, "Nexthop device required for onlink"); return -ENODEV; + } if (!(dev->flags & IFF_UP)) { NL_SET_ERR_MSG(extack, "Nexthop device is not up"); |