diff options
| author | Tejun Heo <tj@kernel.org> | 2017-07-19 01:41:52 +0300 |
|---|---|---|
| committer | Tejun Heo <tj@kernel.org> | 2017-07-19 18:24:19 +0300 |
| commit | 5c0338c68706be53b3dc472e4308961c36e4ece1 (patch) | |
| tree | 306525a446f682b5479f020c7976729bdae52139 /.cocciconfig | |
| parent | 74cbd96bc2e00f5daa805e2ebf49e998f7045062 (diff) | |
| download | linux-5c0338c68706be53b3dc472e4308961c36e4ece1.tar.xz | |
workqueue: restore WQ_UNBOUND/max_active==1 to be ordered
The combination of WQ_UNBOUND and max_active == 1 used to imply
ordered execution. After NUMA affinity 4c16bd327c74 ("workqueue:
implement NUMA affinity for unbound workqueues"), this is no longer
true due to per-node worker pools.
While the right way to create an ordered workqueue is
alloc_ordered_workqueue(), the documentation has been misleading for a
long time and people do use WQ_UNBOUND and max_active == 1 for ordered
workqueues which can lead to subtle bugs which are very difficult to
trigger.
It's unlikely that we'd see noticeable performance impact by enforcing
ordering on WQ_UNBOUND / max_active == 1 workqueues. Let's
automatically set __WQ_ORDERED for those workqueues.
Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Christoph Hellwig <hch@infradead.org>
Reported-by: Alexei Potashnik <alexei@purestorage.com>
Fixes: 4c16bd327c74 ("workqueue: implement NUMA affinity for unbound workqueues")
Cc: stable@vger.kernel.org # v3.10+
Diffstat (limited to '.cocciconfig')
0 files changed, 0 insertions, 0 deletions