starfive-tech/u-boot.git/tools/kwboot.c, branch rtthread_AMP

tools: kwboot: Fix checking image header version

2021-07-31T07:49:32+00:00

Function image_version() returns unsigned value, so it can never be negative. Explicitly check for two supported image versions: v0 and v1. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Stefan Roese

tools: kwboot: Check for v1 header size

2021-07-31T07:49:32+00:00

Too small invalid headers may cause kwboot to crash. Check for header size of v1 images. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Stefan Roese Reviewed-by: Chris Packham Tested-by: Chris Packham

tools: kwboot: Cosmetic fix - add missing curly brackets

2021-07-31T07:49:32+00:00

Add missing curly brackets for this else statement. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Stefan Roese Reviewed-by: Chris Packham Tested-by: Chris Packham

tools: kwboot: Print trailing newline after terminal is terminated

2021-07-31T07:49:31+00:00

Print trailing newline as the last printed byte can be something different. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Stefan Roese Reviewed-by: Chris Packham Tested-by: Chris Packham

tools: kwboot: Fix restoring terminal

2021-07-31T07:49:31+00:00

Call tcsetattr() only if the file descriptor is valid. It may be invalidated by previous lines (if it is not a tty descriptor). Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Stefan Roese Reviewed-by: Chris Packham Tested-by: Chris Packham

tools: kwboot: Fix wrong parameter passed to read()

2021-07-31T07:49:31+00:00

The 'buf' variable is a pointer and '_buf' is the array itself. Therefore we should pass sizeof(_buf) instead of sizeof(buf) to read(). Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Stefan Roese Reviewed-by: Chris Packham Tested-by: Chris Packham

tools: kwbimage: Mark all BootROM structures __packed

2021-07-31T07:49:31+00:00

These structures must have specific size without padding, so mark them as packed via the de-facto standard macro __packed. Also replace PACKED macro. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Stefan Roese

tools: kwboot: Make kwboot more robust on a38x

2018-09-19T06:59:26+00:00

This patch accomplishes 2 things to make the kwboot procedure on the a38x more reliable. 1) We fill the tty with 1K of the magic bootparam. This helps with the timing of where the microcode picks up in the read of the line to ensure we actually catch the break to go into recovery mode 2) Before starting the xmodem transfer we sleep for 2 seconds and then flush the line. This allows all the magic bootparam to be flushed from the line and makes the xmodem transfer reliable and removes the Bad message failures. Signed-off-by: Jon Nettleton Signed-off-by: Baruch Siach Reviewed-by: Chris Packham Signed-off-by: Stefan Roese

tools: kwboot: properly quit when read() returns 0

2018-08-07T08:53:52+00:00

When kwboot is attached to a terminal which disappears such as one connected via an unplugged USB cable, read() returns 0, making kwboot loop until a key is pressed in the terminal. The only case where read() may return 0 here is when the terminal is closed anyway, so let's properly handle this one and report is similar to other errors. Signed-off-by: Willy Tarreau Signed-off-by: Stefan Roese

tools: kwboot: unbreak terminal-only mode

2018-08-07T08:53:52+00:00

Commit 84899e2 ("tools/kwboot: Sync with latest barebox version to support Armada XP") accidently broke the terminal-only mode (-t) by removing the test on the bootmsg. Thus even when trying to use kwboot as a plain terminal, it asks to reboot the target. This commit simply reintroduces the lost test so that it is possible again to use kwboot to attach to the target system's console. Signed-off-by: Willy Tarreau Signed-off-by: Stefan Roese