starfive-tech/u-boot.git/tools/kwbimage.c, branch rtthread_AMP

tools: kwbimage: Remove comment about unimplemented register headers in v1 images

2021-09-01T06:09:24+00:00

Support for register headers in v1 images was implemented in commit 02ba70ad6822 ("tools: kwbimage: Add support for DATA command also for v1 images"). So remove old comment. Signed-off-by: Pali Rohár Fixes: 02ba70ad6822 ("tools: kwbimage: Add support for DATA command also for v1 images") Reviewed-by: Stefan Roese

kwbimage: check return value of image_get_csk_index

2021-09-01T06:09:24+00:00

image_get_csk_index() may return -1 in case of an error. Don't use this value as index. This resolves Coverity CID 338488 Memory - illegal accesses (NEGATIVE_RETURNS) Signed-off-by: Heinrich Schuchardt Reviewed-by: Stefan Roese Reviewed-by: Pali Rohár

kwbimage: check fopen() return value

2021-09-01T06:09:24+00:00

Always check the return value of fopen(). This resolves Coverity CID 338491: Null pointer dereferences (NULL_RETURNS) Signed-off-by: Heinrich Schuchardt Reviewed-by: Stefan Roese Reviewed-by: Pali Rohár

tools: kwbimage: Use IBR_HDR_* constants instead of raw numbers

2021-09-01T06:07:04+00:00

There are already IBR_HDR_* constants for these numbers, so use them. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese

tools: kwbimage: Verify size of image data

2021-09-01T06:07:04+00:00

Part of image data is 4 byte checksum, so every image must contain at least 4 bytes. Verify it to prevent memory corruptions. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese

tools: kwbimage: Verify size of v0 image header

2021-09-01T06:07:04+00:00

Check that extended image header size is not larger than file size. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese

tools: kwbimage: Verify supported image version

2021-09-01T06:07:04+00:00

Only image versions 0 and 1 are supported. Verify it in kwbimage_verify_header() function. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese

kwbimage: Update help message about how to extract from an existing image

2021-07-31T07:59:58+00:00

Extracting is now supported by dumpimage, so mention it in help instead of `kwbimage -x`. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Stefan Roese

kwbimage: Add support for extracting images via dumpimage tool

2021-07-31T07:59:58+00:00

The kwbimage library does not support extracting subimages. Implement it. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Stefan Roese

tools: kwbimage: Remove v1 kwbimage SPL padding to CONFIG_SYS_U_BOOT_OFFS bytes

2021-07-31T07:59:58+00:00

This padding depends on board config file and therefore it makes the mkimage binary tool board specific, which is not correct. One cannot use mkimage tool built as a result for board A to generate images for board B, even if both A and B are on the same platform. This CONFIG_SYS_U_BOOT_OFFS padding was needed when kwbimage v1 contained SPL code which loaded U-Boot proper based on CONFIG_SYS_U_BOOT_OFFS, instead of reading correct offset from kwbimage header. Now that SPL code parses kwbimage header and deterinate correct offset, there is no need for this CONFIG_SYS_U_BOOT_OFFS padding anymore. By removing it we also reduce the size of SPL code and therefore also decrease the final size of v1 kwbimage. This means there is more space for U-Boot proper binary. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Reviewed-by: Chris Packham Reviewed-by: Stefan Roese