starfive-tech/u-boot.git/common/xyzModem.c, branch master

xyz-modem: Allow to cancel transfer also by CTRL+C

2021-09-03T18:32:41+00:00

Currently it is possible to cancel loadx and loady commands by pressing CTRL+X (CAN character) at least 3 times quickly. All other U-Boot commands, including loadb and loads can be cancelled by CTRL+C. So allow it also in xyz-modem code used by loadx and loady commands. Implement it by handling CTRL+C (ETX character) in the same way as CTRL+X (CAN character). Due to how x/y-modem protocol works, it is required to press CTRL+C or CTRL+X at least 3 times quickly. Signed-off-by: Pali Rohár Reviewed-by: Simon Glass

xyz-modem: Put xyzModem_stream_close debug diagnostic message into ZM_DEBUG()

2021-09-03T18:32:40+00:00

This is how all other debug / diagnostic messages are handled. Signed-off-by: Pali Rohár

xyz-modem: Fix x-modem "xyzModem_eof error" at the end of file

2021-09-03T18:32:40+00:00

In x-modem protocol EOF is not an error state at the end of file. Signed-off-by: Pali Rohár Reviewed-by: Simon Glass

xyz-modem: Fix crash after cancelling transfer

2021-09-03T18:32:40+00:00

Variable xyz.len is set to -1 on error. At the end xyzModem_stream_read() function calls memcpy() with length from variable xyz.len. If this variable is set to -1 then value passed to memcpy is casted to unsigned value, which means to copy whole address space. Which then cause U-Boot crash. E.g. on arm64 it cause CPU crash: "Synchronous Abort" handler, esr 0x96000006 Fix this issue by checking that value stored in xyz.len is valid prior trying to use it. Signed-off-by: Pali Rohár Acked-by: Heinrich Schuchardt

common: rename getc() to getchar()

2020-10-22T13:54:53+00:00

The sandbox is built with the SDL2 library with invokes the X11 library which in turn calls getc(). But getc() in glibc is defined as int getc(FILE *) This does not match our definition. int getc(void) The sandbox crashes when called with parameter -l. Rename our library symbol getc() to getchar(). Signed-off-by: Heinrich Schuchardt Reviewed-by: Tom Rini Reviewed-by: Simon Glass

spl: Allow tiny printf() to be controlled in SPL and TPL

2019-10-08T05:57:45+00:00

At present there is only one control for this and it is used for both SPL and TPL. But SPL might have a lot more space than TPL so the extra cost of a full printf() might be acceptable. Split the option into two, providing separate SPL and TPL controls. The TPL setting defaults to the same as SPL. Signed-off-by: Simon Glass Reviewed-by: Bin Meng

xyz-modem: Fix timeout loop waiting with WATCHDOG

2019-01-15T20:28:51+00:00

Commit 2c77c0d6524eb ("xyz-modem: Change getc timeout loop waiting") fixes the loop delay when using a hw watchdog, assuming that watchdog kicking is taken care of by getc(). But the xyzmodem driver tries to do a getc only after confirming that a character is available like below: while (!tstc()) { till timeout; } if (tstc()) *c = getc(); and getc() does a watchdog reset only if it fails to see a character. In this case, getc() always sees a character and never does a watchdog reset. So to make sure that watchdog doesn't get reset while loading the file, do a watchdog reset just before starting the image loading. Signed-off-by: Lokesh Vutla Signed-off-by: Vignesh R Reviewed-by: Simon Glass

lib: merge CRC16-CCITT into u-boot/crc.h

2018-12-09T01:18:32+00:00

This merges the CRC16-CCITT headers into u-boot/crc.h to prepare for rolling CRC16 into the hash infrastructure. Given that CRC8, CRC32 and CRC32-C already have their prototypes in a single header file, it seems a good idea to also include CRC16-CCITT in the same. Signed-off-by: Philipp Tomsich

xyz-modem: va_start() must be matched by va_end()

2018-05-11T00:38:34+00:00

Every va_start() call must be matched by a va_end() call. scripts/checkpatch.pl required reformatting the complete function zm_dprintf(). Signed-off-by: Heinrich Schuchardt

Fix Ymodem build when DEBUG and CONFIG_USE_TINY_PRINTF are selected

2018-05-11T00:38:33+00:00

Attempting to build with both DEBUG and CONFIG_USE_TINY_PRINTF along with CONFIG_SPL_YMODEM_SUPPORT fails at link time: common/built-in.o: In function `zm_dprintf': common/xyzModem.c:190: undefined reference to `vsprintf' Disable Ymodem debug if we don't have full vsprintf support. Signed-off-by: Alex Kiernan Reviewed-by: Joe Hershberger