starfive-tech/opensbi.git/platform, branch SDK_v2.1.0

platform: sifive_fu740: fix reset when watchdog is running

2022-01-21T16:14:57+00:00

When the watchdog is running the HiFive Unmatched board does not reboot properly and shuts down itself a few seconds after reboot, in the early stages of the u-boot loading. On a Linux kernel this happens when the da9063_wdt module is loaded. This does not happen if the module is unloaded before reboot or if the watchdog module is loaded with "stop_on_reboot=1". Fix that by stopping the watchdog before attempting to reset the board. This is done by zeroing the TWDSCALE field of CONTROL_D register, unless it was already set to 0. Reported-by: Tianon Gravi Signed-off-by: Aurelien Jarno Reviewed-by: Nikita Shubin Tested-by: Nikita Shubin Reviewed-by: Anup Patel

platform: sifive_fu740: do not use a global in da9063_reset/shutdown

2022-01-21T16:11:33+00:00

da9063_reset() and da9063_shutdown() take the chip address in argument (like similar functions), but in practice use the da9063 global struct instead. Fix that. Signed-off-by: Aurelien Jarno Reviewed-by: Nikita Shubin Reviewed-by: Anup Patel Reviewed-by: Xiang W

lib: sbi: Improve fatal error handling

2021-12-02T03:20:36+00:00

BUG and BUG_ON are not informative and are rather lazy interfaces, only telling the user that something went wrong in a given function, but not what, requiring the user to find the sources corresponding to their firmware (which may not be available) and figure out how that BUG(_ON) was hit. Even SBI_ASSERT in its current form, which does include the condition that triggered it in the output, isn't necessarily very informative. In some cases, the error may be fixable by the user, but they need to know the problem in order to have any hope of fixing it. It's also a nuisance for developers, whose development trees may have changed significantly since the release in question being used, and so line numbers can make it harder for them to understand which error case a user has hit. This patch introduces a new sbi_panic function which is printf-like, allowing detailed error messages to be printed to the console. BUG and BUG_ON are removed, since the former is just a worse form of sbi_panic and the latter is a worse version of SBI_ASSERT. Finally, SBI_ASSERT is augmented to take a set of arguments to pass to sbi_panic on failure, used like so (sbi_boot_print_hart's current error case, which currently manually calls sbi_printf and sbi_hart_hang): SBI_ASSERT(xlen >= 1, ("Error %d getting MISA XLEN\n", xlen)); The existing users of BUG are replaced with calls to sbi_panic along with informative error messages. BUG_ON and SBI_ASSERT were unused (and, in the case of SBI_ASSERT, remain unused). Many existing users of sbi_hart_hang should be converted to use either sbi_panic or SBI_ASSERT after this commit. Signed-off-by: Jessica Clarke Reviewed-by: Anup Patel Reviewed-by: Xiang W Reviewed-by: Atish Patra

platform: sifive_fu740: add platform reset driver

2021-11-12T04:59:20+00:00

da9063 PMIC can be used to reset/shutdown the Sifive Unmatched board. shutdown is done simply by writing SHUTDOWN bit to DA9063_REG_CONTROL_F register. reset via setting WAKEUP bit in DA9063_REG_CONTROL_F register followed by masking POWER and POWER1 domains and setting STANDBY bit in DA9063_REG_CONTROL_A, originally discovered by Alexandre Ghiti on linux-riscv maillists. Tested-by: Heinrich Schuchardt Reviewed-by: Alexandre Ghiti Tested-by: Alexandre Ghiti Signed-off-by: Nikita Shubin

platform: generic: move fdt_reset_init to final_init

2021-11-08T05:12:05+00:00

Move the fdt_reset_init() invocation from generic_early_init() to generic_final_init(). This allows to print error messages. Ignore the return value of fdt_reset_init() as we should not stop booting due to failure to initialize reset drivers. Signed-off-by: Heinrich Schuchardt Reviewed-by: Dong Du Reviewed-by: Anup Patel

include: sbi_utils: Introduce an helper to get fdt base address

2021-11-02T05:53:16+00:00

This simply adds an helper to get fdt address which is more explicit than sbi_scratch_thishart_arg1_ptr. Signed-off-by: Alexandre Ghiti Reviewed-by: Xiang W Reviewed-by: Anup Patel

lib: sbi: convert reset to list

2021-10-11T04:29:29+00:00

To support different handlers for different types of resets, we are adding a sbi_list of restart handlers. Instead of sbi_system_reset_set_device we use sbi_system_reset_add_device to reflect the actual meaning. Signed-off-by: Nikita Shubin Reviewed-by: Anup Patel

lib: sbi: Add timer frequency to struct sbi_timer_device

2021-09-26T14:22:10+00:00

Generic mdelay() and udelay() functions can be provided by the sbi_timer framework if timer frequency is available in the timer instance provided by the platform support or timer driver. This patch adds timer frequency (timer_freq) member in the struct sbi_timer_device for above purpose. Signed-off-by: Anup Patel Reviewed-by: Bin Meng Reviewed-by: Xiang W

lib: utils/timer: Allow separate base addresses for MTIME and MTIMECMP

2021-08-14T03:32:33+00:00

We extend the ACLINT library to support separate base addresses for MTIME and MTIMECMP registers. Signed-off-by: Anup Patel Reviewed-by: Atish Patra

lib: utils/fdt: Change addr and size to uint64_t

2021-08-07T11:56:51+00:00

The maximum address and size encoded in DT are 64-bit numbers, so we should use uint64_t for 'addr' and 'size' in fdt_get_node_addr_size(). Signed-off-by: Bin Meng Reviewed-by: Anup Patel