starfive-tech/opensbi.git/lib/utils/fdt, branch rtthread_AMP

lib: sbi: Add system_suspend_allowed domain property

2023-02-27T14:15:28+00:00

Only privileged domains should be allowed to suspend the entire system. Give the root domain this property by default and allow other domains to be given the property by specifying it in the DT. Signed-off-by: Andrew Jones Reviewed-by: Anup Patel

lib: utils/fdt/fdt_domain: Simplify region access permission check

2023-02-27T08:19:21+00:00

The region access permission check in __fdt_parse_region() can be simplified as masking SBI_DOMAIN_MEMREGION_{M,SU}_ACCESS_MASK is enough. While we are here, update the confusing comments to match the codes. Signed-off-by: Bin Meng Reviewed-by: Anup Patel

lib: utils: fdt_fixup: Fix compile error

2023-02-27T05:19:09+00:00

When building with GCC-10 or older versions, it throws the following error: CC-DEP platform/generic/lib/utils/fdt/fdt_fixup.dep CC platform/generic/lib/utils/fdt/fdt_fixup.o lib/utils/fdt/fdt_fixup.c: In function 'fdt_reserved_memory_fixup': lib/utils/fdt/fdt_fixup.c:376:2: error: label at end of compound statement 376 | next_entry: | ^~~~~~~~~~ Remove the goto statement. Resolves: https://github.com/riscv-software-src/opensbi/issues/288 Signed-off-by: Yu Chien Peter Lin Signed-off-by: Xiang W Reviewed-by: Anup Patel Reviewed-by: Bin Meng

lib: utils/fdt: Fix fdt_pmu.c header dependency

2023-02-27T04:29:01+00:00

The code calls sbi_scratch_thishart_ptr() from sbi_scratch.h which is not directly included. Fix such dependency. Signed-off-by: Bin Meng Reviewed-by: Anup Patel

lib: utils: Mark only the largest region as reserved in FDT

2023-02-08T05:43:19+00:00

In commit 230278dcf, RX and RW regions were marked separately. When the RW region grows (e.g. with more harts) and it isn't a power-of-two, sbi_domain_memregion_init will upgrade the region to the next power-of-two. This will make RX and RW both start at the same base address, like so (with 64 harts): Domain0 Region01 : 0x0000000080000000-0x000000008001ffff M: (R,X) S/U: () Domain0 Region02 : 0x0000000080000000-0x00000000800fffff M: (R,W) S/U: () This doesn't break the permission enforcement because of static priorities in PMP but makes the kernel complain about the regions overlapping each other. Like so: [ 0.000000] OF: reserved mem: OVERLAP DETECTED! [ 0.000000] mmode_resv0@80000000 (0x0000000080000000--0x0000000080020000) \ overlaps with mmode_resv1@80000000 (0x0000000080000000--0x0000000080100000) To fix this warning, among the multiple regions having same base address but different sizes, add only the largest region as reserved region during fdt fixup. Fixes: 230278dcf (lib: sbi: Add separate entries for firmware RX and RW regions) Signed-off-by: Himanshu Chauhan Reviewed-by: Anup Patel

lib: utils: Add fdt_add_cpu_idle_states() helper function

2023-01-24T12:00:21+00:00

Since the availability and latency properties of CPU idle states depend on the specific SBI HSM implementation, it is appropriate that the idle states are added to the devicetree at runtime by that implementation. This helper function adds a platform-provided array of idle states to the devicetree, following the SBI idle state binding. Reviewed-by: Anup Patel Signed-off-by: Samuel Holland

lib: utils: Fix reserved memory node for firmware memory

2023-01-22T12:19:10+00:00

The commit 9e0ba090 introduced more fine grained permissions for memory regions and did not update the fdt_reserved_memory_fixup() function. As a result, the fdt_reserved_memory_fixup continued to use the older coarse permissions which causes the reserved memory node to be not inserted into the DT. To fix the above issue, we correct the flags used for memory region permission checks in the fdt_reserved_memory_fixup() function. Fixes: 9e0ba090 ("include: sbi: Fine grain the permissions for M and SU modes") Signed-off-by: Mayuresh Chitale Reviewed-by: Anup Patel

lib: utils: Disallow non-root domains from adding M-mode regions

2023-01-09T12:34:25+00:00

The M-mode regions can only be added to the root domain. The non-root domains shouldn't be able to add them from FDT. Signed-off-by: Himanshu Chauhan Reviewed-by: Anup Patel Tested-by: Anup Patel

lib: utils: Use SU-{R/W/X} flags for region permissions during parsing

2023-01-09T12:34:23+00:00

Use the newer SU-{R/W/X} flags for checking and assigning region permissions. Signed-off-by: Himanshu Chauhan Reviewed-by: Anup Patel Tested-by: Anup Patel

treewide: Replace TRUE/FALSE with true/false

2023-01-06T11:56:35+00:00

C language standard uses true/false for the boolean type. Let's switch to that for better language compatibility. Signed-off-by: Bin Meng Reviewed-by: Anup Patel Reviewed-by: Samuel Holland Tested-by: Samuel Holland