starfive-tech/opensbi.git/lib/sbi, branch masterStarFive Tech OpenSBI for VisionFive (JH7110) boards (mirror)https://git.radix-linux.su/starfive-tech/opensbi.git/atom?h=master2025-02-19T16:43:21+00:00lib: sbi: fwft: Return SBI_ERR_DENIED_LOCKED when setting a locked feature2025-02-19T16:43:21+00:00Clément Légercleger@rivosinc.com2025-01-24T16:51:57+00:00urn:sha1:1ad199124479b9944d5dddc2119e6da9f088f7a7
Latest modifications to the spec mandates that a set on a lock feature
returns SBI_ERR_DENIED_LOCKED.
Signed-off-by: Clément Léger <cleger@rivosinc.com>
Reviewed-by: Anup Patel <anup@brainfault.org>
lib: sbi: sse: fix invalid errors returned for sse_hart_mask/unmask()2025-02-19T11:48:13+00:00Clément Légercleger@rivosinc.com2025-02-13T09:25:03+00:00urn:sha1:f354400ebf91f2988a20da52a6399ac51988fc95
When called twice, sse_hart_mask()/sse_hart_unmask() should return
SBI_EALREADY_STOPPED/SBI_EALREADY_STARTED. This was currently inverted.
Fixes: b919daf49582 ("lib: sbi: Add support to mask/unmask SSE events")
Reported-by: Andrew Jones <ajones@ventanamicro.com>
Signed-off-by: Clément Léger <cleger@rivosinc.com>
Reviewed-by: Samuel Holland <samuel.holland@sifive.com>
Reviewed-by: Anup Patel <anup@brainfault.org>
lib: sbi: Fix non-root domain startup2025-02-19T11:41:39+00:00Anup Patelapatel@ventanamicro.com2025-02-11T15:36:23+00:00urn:sha1:1f64fef919fc5739df6c3395a9abd256dc88cb24
Currently, the sbi_sse_init() in cold boot path is called after
sbi_domain_finalize() so boot HART of non-root domains will start
before SSE cold boot init which can cause warm boot of such HARTs
to crash in sbi_sse_init().
To address the above issue, factor-out the non-root domain startup
from sbi_domain_finalize() function as a separate sbi_domain_startup()
function which can be called after sbi_sse_init() in cold boot path.
Fixes: 93f7d819fdeb ("lib: sbi: sse: allow adding new events")
Signed-off-by: Anup Patel <apatel@ventanamicro.com>
lib: sbi: Update MPXY framework and SBI extension as per latest spec2025-02-13T05:40:03+00:00Anup Patelapatel@ventanamicro.com2025-01-21T12:06:29+00:00urn:sha1:ec09918426a5ccff5de09cd41c3f36d0ad5443f1
The latest SBI 3.0 spec defines a new sbi_mpxy_get_shmem_size()
function and simplifies sbi_mpxy_set_shmem() function so update
the MPXY framework and SBI extension accordingly.
Signed-off-by: Anup Patel <apatel@ventanamicro.com>
lib: sbi: Improve local variable declarations in MPXY framework2025-02-13T05:40:03+00:00Anup Patelapatel@ventanamicro.com2025-01-12T05:05:40+00:00urn:sha1:a4876e6c6c92f5c94809c5d8a82ad037184414ce
The local variable declarations should be at the start of function
and preferrably organized like a inverted pyramid.
Signed-off-by: Anup patel <apatel@ventanamicro.com>
Reviewed-by: Samuel Holland <samuel.holland@sifive.com>
lib: sbi: Fix capability bit assignment in MPXY framework2025-02-13T05:40:03+00:00Anup Patelapatel@ventanamicro.com2025-01-12T04:52:40+00:00urn:sha1:30437eb2042c163bd1dc2870ba239514230b7233
The capability bit assignment in MPXY framework does not match the
SBI MPXY extension in latest SBI specification so update it.
Fixes: 7939bf1329eb ("lib: sbi: Add SBI Message Proxy (MPXY) framework")
Signed-off-by: Anup patel <apatel@ventanamicro.com>
Reviewed-by: Samuel Holland <samuel.holland@sifive.com>
lib: sbi: increase the size of the string used for extension display2025-02-13T03:46:05+00:00Clément Légercleger@rivosinc.com2025-01-23T14:58:05+00:00urn:sha1:5ce121b7a102432492a279dd026e494640186483
With the "max" QEMU cpu, the displayed extension string is truncated due
to the buffer being too small. Increase it to 256 to display the full
set of extensions correctly.
Signed-off-by: Clément Léger <cleger@rivosinc.com>
Reviewed-by: Anup Patel <anup@brainfault.org>
lib: sbi: pmu: add the PMU SSE event only if overflow IRQ is supported2025-01-30T05:13:16+00:00Clément Légercleger@rivosinc.com2025-01-10T13:15:56+00:00urn:sha1:5c7e2c8334325e9e1e2e0541863812146efacb0d
Add the PMU SSE event only if an overflow irq bit is present.
Signed-off-by: Clément Léger <cleger@rivosinc.com>
Reviewed-by: Samuel Holland <samuel.holland@sifive.com>
Reviewed-by: Atish Patra <atishp@rivosinc.com>
lib: sbi: sse: return SBI_ENOTSUPP for unsupported events2025-01-30T05:12:27+00:00Clément Légercleger@rivosinc.com2025-01-10T13:15:55+00:00urn:sha1:ecab71e19a951a0e42dbbb81b0e4d43840551f7e
If a standard event was not found in the list of events that are handled
by harts but belongs to the standard event list defined by the
specification, return SBI_ENOTSUPP. Without that, we can not
distinguish a non implemented standard event from a non valid one.
Signed-off-by: Clément Léger <cleger@rivosinc.com>
Reviewed-by: Samuel Holland <samuel.holland@sifive.com>
Reviewed-by: Atish Patra <atishp@rivosinc.com>
lib: sbi: sse: allow adding new events2025-01-30T05:10:49+00:00Clément Légercleger@rivosinc.com2025-01-10T13:15:54+00:00urn:sha1:93f7d819fdeb3c5e82d5d761968c325f1407d517
In order to allow events to be dynamically added, remove the existing
static array of events and use a simply linked list of supported events.
This allows us to move the cb_ops into this list and associated it with
an event_id. Drivers can now register cb_ops before bringing up the sse
core to handle additional events (platform ones for instance).
sbi_sse_init() now allocates as many events as present in the linked
list. Events can now be added with sbi_sse_add_event() which allows to
add new supported events with some callback operations if any. If an
event is not to be supported, then sbi_sse_add_event() should not be
called. This approach currently consider that local events are to be
supported on all harts (ie, they all support the same ISA or
dependencies). If per-hart event availability needs to be supported,
then, an is_supported() callback could be added later and called for
each hart.
Signed-off-by: Clément Léger <cleger@rivosinc.com>
Reviewed-by: Samuel Holland <samuel.holland@sifive.com>