starfive-tech/opensbi.git/lib/sbi/sbi_init.c, branch rtthread_AMP

lib: sbi: Clear IPIs before init_warm_startup in non-boot harts

2023-03-10T08:43:40+00:00

Since commit 50d4fde1c5a4 ("lib: Remove redundant sbi_platform_ipi_clear() calls"), the IPI sent from the boot hart in wake_coldboot_harts() is not cleared in the secondary harts until they reach sbi_ipi_init(). However, sbi_hsm_init() and sbi_hsm_hart_wait() are called earlier, so a secondary hart might enter sbi_hsm_hart_wait() with an already pending IPI. sbi_hsm_hart_wait() makes sure the hart leaves the loop only when it is actually ready, so a pending unrelated IPI should not cause safety issues. However, it might be inefficient on certain hardware, because it prevents "wfi" from stalling the hart even if the hardware supports this, making the hart needlessly spin in a "busy-wait" loop. This behaviour can be observed, for example, in a QEMU VM (QEMU 7.2.0) with "-machine virt" running a Linux guest. Inserting delays in sbi_hsm_hart_start() allows reproducing the issue more reliably. The comment in wait_for_coldboot() suggests that the initial IPI is needed in the warm resume path, so let us clear it before init_warm_startup() only. To do this, sbi_ipi_raw_clear() was created similar to sbi_ipi_raw_send(). Signed-off-by: Evgenii Shatokhin Reviewed-by: Anup Patel

lib: sbi: Refactor the calls to sbi_hart_switch_mode()

2023-03-10T08:30:36+00:00

Move them into sbi_hsm_hart_start_finish() and sbi_hsm_hart_resume_finish() to make them easier to manage. This will be used by subsequent patches. Suggested-by: Anup Patel Signed-off-by: Evgenii Shatokhin Reviewed-by: Anup Patel

lib: sbi: Add system suspend skeleton

2023-02-27T14:13:52+00:00

Add the SUSP extension probe and ecall support, but for now the system suspend function is just a stub. Signed-off-by: Andrew Jones Reviewed-by: Anup Patel

lib: sbi: Print the RW section offset

2023-01-23T04:36:14+00:00

Print the RW section offset when firmware base and size is being printed. Signed-off-by: Himanshu Chauhan Reviewed-by: Anup Patel

lib: sbi: Allow platform to influence cold boot HART selection

2023-01-07T10:28:49+00:00

We add an optional cold_boot_allowed() platform callback which allows platform support to decide which HARTs can do cold boot initialization. If this platform callback is not available then any HART can do cold boot initialization. Signed-off-by: Anup Patel

treewide: Replace TRUE/FALSE with true/false

2023-01-06T11:56:35+00:00

C language standard uses true/false for the boolean type. Let's switch to that for better language compatibility. Signed-off-by: Bin Meng Reviewed-by: Anup Patel Reviewed-by: Samuel Holland Tested-by: Samuel Holland

lib: sbi: Print platform PMU device at boot-time

2022-09-01T11:23:25+00:00

Let us print the platform PMU device name at the boot-time so that users know whether the underlying platform has custom per-HART PMU operations. Signed-off-by: Anup Patel Reviewed-by: Andrew Jones Reviewed-by: Atish Patra

lib: sbi: Convert hart features into hart extensions

2022-05-07T04:46:30+00:00

Since past few years, we have been using "hart features" in OpenSBI to represent all optionalities and multi-letter extensions defined by the RISC-V specifications. The RISC-V profiles specification has taken a different approach and started assigning extension names for all optionalities which did not have any extension name previously. (Refer, https://github.com/riscv/riscv-profiles/blob/main/profiles.adoc) Inspired from the RISC-V profiles specification, we convert OpenSBI hart features into hart extensions. Going forward, we align the extension naming with RISC-V profiles specification. Currently, only "time CSR" and "AIA CSR" have not been assigned extension name but for everything else we have a name. Signed-off-by: Anup Patel Reviewed-by: Atish Patra

lib: sbi: Update the name of ISA string printed at boot time

2022-05-07T04:33:24+00:00

The ISA string printed at boot time is not the complete ISA string representing all single letter and multi-letter extensions rather it is base ISA string derived from misa CSR so let us update the boot print accordingly. Signed-off-by: Anup Patel Reviewed-by: Atish Patra

lib: sbi: Detect and print privileged spec version

2022-05-07T04:19:54+00:00

It is possible to guess privileged spec versions based on the CSRs that where introduced in different privileged spec versions. In future, if we are not able guess privileged spec version then we can have platform provide it. We add privileged spec version as per-hart feature and try to guess it based on presence of mcounteren, mcountinhibit, and menvcfg CSRs. Signed-off-by: Anup Patel Reviewed-by: Atish Patra