starfive-tech/opensbi.git/firmware, branch starfive-dubhe

firmware: use _fw_start for load address

2021-07-27T09:50:49+00:00

The previous code uses _start as the load address, this default .entry is the first segment, using _fw_start does not need to make this assumption. Signed-off-by: Xiang W Reviewed-by: Anup Patel

firmware: Remove the unhelpful alignment codes before fdt relocation

2021-07-17T11:43:43+00:00

If the device tree is at an address that is not __SIZEOF_POINTER__ aligned, the fdt relocation code tries to align both source and destination address to __SIZEOF_POINTER__ before the memory copy. But such alignment can lead to unexpected results if either source or destination address is not aligned. In fact libfdt requires that the device tree must be at an 8-byte aligned address. Hence remove the unhelpful alignment codes. Signed-off-by: Bin Meng Reviewed-by: Anup Patel

firmware: Only default FW_PIC to y if supported

2021-07-11T14:33:06+00:00

Bare-metal GNU ld does not support PIE, so if using it this will result in a failure to build. Instead, default to FW_PIC=n if not supported. Note that an explicit FW_PIC=y is not overridden, to ensure the build fails rather than silently producing a position-dependent binary. Signed-off-by: Jessica Clarke Reviewed-by: Bin Meng Tested-by: Bin Meng Reviewed-by: Anup Patel

firmware: Explicitly pass -pie to the linker, not just the driver

2021-07-11T14:31:56+00:00

When using Clang with a bare-metal triple, -pie does not get passed to the linker as it's not normally a thing that makes sense, unlike GCC which will unconditionally forward it on and potentially result in a linker error. However, LLD does support it, and manually forwarding it on works as desired, so do so to fully support FW_PIC with Clang and LLD. Signed-off-by: Jessica Clarke Reviewed-by: Bin Meng Tested-by: Bin Meng Reviewed-by: Anup Patel

fw_base: Put data in .data rather than .text

2021-07-11T12:03:30+00:00

The -N linker option is supposed to make .text writable, but GNU ld and LLD differ in interpreting what that means. GNU ld will happily let you have relocations in it, but LLD will see that the input section is read-only (even though the output section is writable) and give an error. It's unclear if either of them intend to have that behaviour in this edge case, but regardless there's no reason not to just put the data in a writable .data section. Signed-off-by: Jessica Clarke Reviewed-by: Bin Meng Tested-by: Bin Meng Reviewed-by: Anup Patel

fw_base: Don't mark fw_platform_init as both global and weak

2021-07-11T11:50:42+00:00

These are mutually exclusive. GNU as and LLVM both let later binding directives override earlier ones so this works as intended, but LLVM 12 turned this into a warning as there's no good reason to do such a thing and could be a potential bug. Thus, remove the redundant and incorrect .globl directive for fw_platform_init. Signed-off-by: Jessica Clarke Reviewed-by: Bin Meng Tested-by: Bin Meng Reviewed-by: Anup Patel

firmware: Define a macro for version of struct fw_dynamic_info

2021-07-11T08:43:32+00:00

Avoid using a magic number, instead use a macro for the version of struct fw_dynamic_info. Signed-off-by: Bin Meng Reviewed-by: Xiang W Reviewed-by: Anup Patel

firmware: Remove the sanity checks in fw_save_info()

2021-07-11T08:39:10+00:00

The sanity checks on the magic and version was already done in fw_boot_hart(), which happens before fw_save_info() is called. Signed-off-by: Bin Meng Reviewed-by: Xiang W Reviewed-by: Anup Patel

firmware: Minor optimization in _scratch_init()

2021-07-11T06:11:50+00:00

Before entering _scratch_init(), register t3 already holds a copy of the firmware end address, hence there is no need to calculate it again. This reduces 3 instructions in each _scratch_init() loop. Signed-off-by: Bin Meng Reviewed-by: Xiang W Reviewed-by: Atish Patra

firmware: Enable FW_PIC by default

2021-04-28T10:08:22+00:00

Let's have FW_PIC enabled by default so that OpenSBI firmware can by default run from any physical address. Tested with qemu_rv32 & rv64, T-HEAD all hardwares. Suggested-by: Anup Patel Signed-off-by: Guo Ren Tested-by: Guo Ren Reviewed-by: Anup Patel