starfive-tech/opensbi.git, branch master

lib: sbi: fwft: Return SBI_ERR_DENIED_LOCKED when setting a locked feature

2025-02-19T16:43:21+00:00

Latest modifications to the spec mandates that a set on a lock feature returns SBI_ERR_DENIED_LOCKED. Signed-off-by: Clément Léger Reviewed-by: Anup Patel

include: sbi: Add SBI_ERR_DENIED_LOCKED

2025-02-19T16:40:59+00:00

Add SBI_ERR_DENIED_LOCKED and set it as the SBI_LAST_ERR which was wrongly set to SBI_ERR_BAD_RANGE. Signed-off-by: Clément Léger Reviewed-by: Anup Patel

lib: utils/irqchip: Match against more specific compatible strings first

2025-02-19T16:19:08+00:00

The T-HEAD C90x PLIC has some special quirks, such as the S-mode delegation bit. OpenSBI currently handles this by checking the compatible string in the device tree. However, this matching is done in the order of the fdt_match array. So if a device tree contains both strings, for example: compatible = "thead,c900-plic", "riscv,plic0"; Then OpenSBI will match against the generic "riscv,plic0" string, since that appears first in the fdt_match array. This means it will fail to set the S-mode delegation bit, and Linux will fail to boot. In some cases, it is not possible to change the compatible string to just the T-HEAD PLIC, as older versions of Linux only recognize the RISC-V compatible string. This patch fixes that by moving the RISC-V string to the end, ensuring that the more specific options get matched first. Signed-off-by: Alex Studer Reviewed-by: Anup Patel

lib: utils/fdt: Allocate fdt_pmu_evt_select on the heap

2025-02-19T12:55:17+00:00

This reduces .bss size by 8 KiB, and should reduce overall memory usage since most platforms will have significantly fewer than 512 entries in this table. At the same time, it removes the fixed table size limit. Since the table is only used within fdt_pmu.c, instead of updating the extern declaration, make the table local to this file. Signed-off-by: Samuel Holland Reviewed-by: Anup Patel

lib: utils/fdt: Remove redundant PMU property length checks

2025-02-19T12:52:52+00:00

If a property value is too small, len will be zero after the division on the next line, so the property will be ignored. This is the same behavior as when the length check fails. Furthermore, the first two length checks were already ineffectual, because each item in those arrays is 12 bytes long, not 8. Signed-off-by: Samuel Holland Reviewed-by: Anup Patel

lib: utils: Constify FDT driver definitions

2025-02-19T12:17:24+00:00

The carray referencing these definitions assumes they are const. Fixes: 6a26726e08e4 ("lib/utils: reset: Add RPMI System Reset driver") Fixes: 13f55f33a1d3 ("lib: utils/suspend: Add RPMI system suspend driver") Fixes: 33ee9b8240fe ("lib: utils/hsm: Add RPMI HSM driver") Fixes: 591a98bdd549 ("lib: utils/cppc: Add RPMI CPPC driver") Signed-off-by: Samuel Holland Reviewed-by: Anup Patel

lib: sbi: sse: fix invalid errors returned for sse_hart_mask/unmask()

2025-02-19T11:48:13+00:00

When called twice, sse_hart_mask()/sse_hart_unmask() should return SBI_EALREADY_STOPPED/SBI_EALREADY_STARTED. This was currently inverted. Fixes: b919daf49582 ("lib: sbi: Add support to mask/unmask SSE events") Reported-by: Andrew Jones Signed-off-by: Clément Léger Reviewed-by: Samuel Holland Reviewed-by: Anup Patel

lib: sbi: Fix non-root domain startup

2025-02-19T11:41:39+00:00

Currently, the sbi_sse_init() in cold boot path is called after sbi_domain_finalize() so boot HART of non-root domains will start before SSE cold boot init which can cause warm boot of such HARTs to crash in sbi_sse_init(). To address the above issue, factor-out the non-root domain startup from sbi_domain_finalize() function as a separate sbi_domain_startup() function which can be called after sbi_sse_init() in cold boot path. Fixes: 93f7d819fdeb ("lib: sbi: sse: allow adding new events") Signed-off-by: Anup Patel

README: Remove comment about boolin toolchains being 64-bit only

2025-02-18T08:40:54+00:00

As of January 2025 they have riscv32-ilp32d and riscv64-lp64d: https://toolchains.bootlin.com/releases_riscv32-ilp32d.html https://toolchains.bootlin.com/releases_riscv64-lp64d.html Signed-off-by: Joel Stanley Reviewed-by: Anup Patel

README: Update toolchain section to mention PIE requirement

2025-02-18T08:40:11+00:00

Since commit 76d7e9b8ee72 ("firmware: remove copy-base relocation"), the Makefile enforces PIE support. Signed-off-by: Joel Stanley Reviewed-by: Anup Patel