From 21532b9e5bd597631cfe38d9eb34df069938065b Mon Sep 17 00:00:00 2001 From: "Tautschnig, Michael" Date: Mon, 4 Jul 2016 13:55:04 +0000 Subject: scripts: Fix size mismatch of kexec_purgatory_size bin2c is used to create a valid C file out of a binary file where two symbols will be globally defined: and _size. is passed as the first parameter of the host binary. Building using goto-cc reported that the purgatory binary code (the only current user of this utility) declares kexec_purgatory_size as 'size_t' where bin2c generate _size to be 'int' so in a 64-bit host where sizeof(size_t) > sizeof(int) this type mismatch will always yield the wrong value for big-endian architectures while for little-endian it will be wrong if the object laid in memory directly after kexec_purgatory_size contains non-zero value at the time of reading. This commit changes _size to be size_t instead. Note: Another way to fix the problem is to change the type of kexec_purgatory_size to be 'int' as there's this check in code: (kexec_purgatory_size <= 0) Signed-off-by: Michael Tautschnig Cc: Vivek Goyal Acked-by: Dave Young Signed-off-by: Michal Marek --- scripts/basic/bin2c.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'scripts') diff --git a/scripts/basic/bin2c.c b/scripts/basic/bin2c.c index af187e695345..c3d7eef3ad06 100644 --- a/scripts/basic/bin2c.c +++ b/scripts/basic/bin2c.c @@ -29,7 +29,8 @@ int main(int argc, char *argv[]) } while (ch != EOF); if (argc > 1) - printf("\t;\n\nconst int %s_size = %d;\n", argv[1], total); + printf("\t;\n\n#include \n\nconst size_t %s_size = %d;\n", + argv[1], total); return 0; } -- cgit v1.2.3