summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2014-05-23staging:rtl8188eu:Remove funtion Hal_CustomizeByCustomerID_8188EU()navin patidar1-5/+0
Function has empty defination. Signed-off-by: navin patidar <navin.patidar@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: rtl8188eu: Remove unused function _ps_close_RF()navin patidar1-7/+0
Signed-off-by: navin patidar <navin.patidar@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: rtl8188eu: Remove function with empty definition _ps_open_RF()navin patidar2-8/+0
Signed-off-by: navin patidar <navin.patidar@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: rtl8188eu: Remove function with empty definition _InitOperationMode()navin patidar1-5/+0
Signed-off-by: navin patidar <navin.patidar@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: rtl8188eu: Remove function with empty definition _InitBeaconMaxError().navin patidar1-8/+0
Signed-off-by: navin patidar <navin.patidar@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: rtl8188eu: remove dead code in rtw_drv_init()Christian Engelmayer1-2/+0
(status != _SUCCESS) immediately after 'status = _SUCCESS' will never evaluate true. Thus remove the logically dead code. Detected by Coverity - CID 1077553. Signed-off-by: Christian Engelmayer <cengelma@gmx.at> Acked-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: rtl8188eu: fix usage of uninit scalar in rtw_drv_init()Christian Engelmayer1-1/+1
Function rtw_drv_init() is written in a way that assumes 'status' != _SUCCESS as long as not explicitly set. Thus initialize 'status' to FAIL, in order to prevent undefined behaviour if going through the exit paths. Detected by Coverity - CID 1077832. Signed-off-by: Christian Engelmayer <cengelma@gmx.at> Acked-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: rtl8188eu: fix potential leak in rtw_set_key()Christian Engelmayer1-8/+11
Fix a potential leak in the error path of rtw_set_key(). In case the requested algorithm is not supported by the driver, the function returns without enqueuing or freeing the already allocated command and parameter structs. Use a centralized exit path and make sure that all memory is freed correctly. Detected by Coverity - CID 1077716, 1077717. Signed-off-by: Christian Engelmayer <cengelma@gmx.at> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: rtl8188eu: fix potential leak in update_bcn_wps_ie()Christian Engelmayer1-4/+4
Fix a potential leak in the error path of function update_bcn_wps_ie(). Move the affected input verification to the beginning of the function so that it may return directly without leaking already allocated memory. Detected by Coverity - CID 1077718. Signed-off-by: Christian Engelmayer <cengelma@gmx.at> Acked-by: Jes Sorensen <Jes.Sorensen@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: rtl8188eu: fix potential leak in rtw_mp_pwrtrk()Christian Engelmayer1-11/+17
Function rtw_mp_pwrtrk() dynamically allocates a temporary buffer that is not freed in all error paths. Use a centralized exit path and make sure that all memory is freed correctly. Detected by Coverity - 1077715. Signed-off-by: Christian Engelmayer <cengelma@gmx.at> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: rtl8188eu: fix potential leak in rtw_mp_SetRFPath()Christian Engelmayer1-3/+8
Function rtw_mp_SetRFPath() dynamically allocates a temporary buffer that is not freed in all error paths. Use a centralized exit path and make sure that all memory is freed correctly. Detected by Coverity - CID 1077714. Signed-off-by: Christian Engelmayer <cengelma@gmx.at> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: rtl8188eu: fix potential leak in rtw_mp_QueryDrv()Christian Engelmayer1-3/+8
Function rtw_mp_QueryDrv() dynamically allocates a temporary buffer that is not freed in all error paths. Use a centralized exit path and make sure that all memory is freed correctly. Detected by Coverity - CID 1077713. Signed-off-by: Christian Engelmayer <cengelma@gmx.at> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: rtl8188eu: fix potential leak in rtw_wx_set_enc_ext()Christian Engelmayer1-1/+3
Function rtw_wx_set_enc_ext() dynamically allocates a temporary buffer that is not freed in all error paths. Use a centralized exit path and make sure that all memory is freed correctly. Detected by Coverity - CID 1077712. Signed-off-by: Christian Engelmayer <cengelma@gmx.at> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: rtl8188eu: fix potential leak in rtw_wx_read32()Christian Engelmayer1-6/+9
Function rtw_wx_read32() dynamically allocates a temporary buffer that is not freed in all error paths. Use a centralized exit path and make sure that all memory is freed correctly. Detected by Coverity - CID 1077711. Signed-off-by: Christian Engelmayer <cengelma@gmx.at> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: rtl8188eu: Remove 'u8 fragcnt' from struct recv_framenavin patidar1-1/+0
Remove unused variable 'u8 fragcnt'. Signed-off-by: navin patidar <navin.patidar@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: rtl8188eu: Remove 'int frame_tag' from struct recv_framenavin patidar1-1/+0
Remove unused variable 'int frame_tag'. Signed-off-by: navin patidar <navin.patidar@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: rtl8188eu: Remove 'void *precvbuf' from struct recv_framenavin patidar2-2/+0
Remove unused variable 'void *precvbuf'. Signed-off-by: navin patidar <navin.patidar@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: rtl8188eu: Remove unused inline function get_rx_status()navin patidar1-5/+0
Signed-off-by: navin patidar <navin.patidar@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: rtl8188eu: Remove unused inline function recvframe_push()navin patidar1-20/+0
Signed-off-by: navin patidar <navin.patidar@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: rtl8188eu: Remove function rtw_os_recvbuf_resource_free()navin patidar3-10/+1
Use usb_free_urb() instead of rtw_os_recvbuf_resource_free() to free URB. Signed-off-by: navin patidar <navin.patidar@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: rtl8188eu: Remove function rtw_hostapd_mlme_rx()navin patidar3-8/+0
rtw_hostapd_mlme_rx() has empty defination, so we can remove it. Signed-off-by: navin patidar <navin.patidar@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: rtl8188eu: Remove function rtw_os_recv_resource_free()navin patidar3-8/+0
rtw_os_recv_resource_free() has empty defination, so we can remove it. Signed-off-by: navin patidar <navin.patidar@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: rtl8188eu: Remove function rtw_os_recv_resource_init()navin patidar3-10/+0
rtw_os_recv_resource_init() has empty defination, so we can remove it. Signed-off-by: navin patidar <navin.patidar@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: rtl8188eu: Remove struct zero_bulkout_contextnavin patidar1-7/+0
Remove unused struct zero_bulkout_context. Signed-off-by: navin patidar <navin.patidar@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: rtl8188eu: Remove 'spinlock_t lock' from struct recv_privnavin patidar2-3/+0
Remove unused variable 'spinlock_t lock'. Signed-off-by: navin patidar <navin.patidar@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: rtl8188eu: Remove unused member variables of struct recv_privnavin patidar1-6/+0
Signed-off-by: navin patidar <navin.patidar@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: rtl8188eu: Remove 'semaphore allrxreturnevt' from struct recv_privnavin patidar2-3/+0
Remove unused variable 'semaphore allrxreturnevt'. Signed-off-by: navin patidar <navin.patidar@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23Staging: rtl8188eu: Fixed prohibited spaces after open '('Remi Pommarel1-3/+3
This patch fixes all prohibited spaces after open '(' checkpatch.pl errors for rtl8188eu. Signed-off-by: Remi Pommarel <repk@triplefau.lt> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: lirc: Fix sparse warningsTuomas Tynkkynen5-47/+52
Fix sparse warnings by adding __user and __iomem annotations where necessary and removing certain unnecessary casts. While at it, also use u32 in place of __u32. Signed-off-by: Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: rtl8192u: r8192U_core.c: Fix to remove null pointer checks that ↵Rickard Strandqvist1-3/+0
could never happen Removal of null pointer checks that could never happen Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging/rtl8192u: Put EXPORT_SYMBOL just after the exported functionBenoit Taine6-70/+52
Export of symbols statement must be placed right after the definition to meet kernel coding style guidelines. This issue was reported by checkpatch. A simplified version of the semantic patch that makes this change is as follows (http://coccinelle.lip6.fr/): // <smpl> @ r @ identifier f; @@ - EXPORT_SYMBOL(f); @@ identifier r.f; @@ f(...) { ... } + EXPORT_SYMBOL(f); // </smpl> Signed-off-by: Benoit Taine <benoit.taine@lip6.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: vt6655: Remove useless return variablesPeter Senna Tschudin2-19/+10
This patch remove variables that are initialized with a constant, are never updated, and are only used as parameter of return. Return the constant instead of using a variable. Verified by compilation only. The coccinelle script that find and fixes this issue is: // <smpl> @@ type T; constant C; identifier ret; @@ - T ret = C; ... when != ret - return ret; + return C; // </smpl> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: vt6656: dead code remove diversity codeMalcolm Priestley5-365/+0
bDiversityRegCtlON is always false. In later vendor driver code has been commented out. Remove diversity timers and variables. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: vt6656: remove dead code tcrc.c/hMalcolm Priestley7-226/+0
Functions are now dead and of no use. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: vt6656: s_vSWencryption replace CRCdwGetCrc32ExMalcolm Priestley1-2/+2
Replace with ether_crc_le which gives the same result. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: vt6656: ETHbIsBufferCrc32Ok replace CRCdwGetCrc32Malcolm Priestley1-3/+3
CRCdwGetCrc32 is a bitwise not of ether_crc_le. Replace with ether_crc_le. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: vt6656: iowpa.h removed dead code.Malcolm Priestley1-53/+0
Remove dead strutures Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: vt6656: iocmd.h remove dead code.Malcolm Priestley1-86/+0
Remove dead strutures and macros. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging/rtl8821ae: avoid format string leak to thread nameKees Cook1-1/+2
This makes sure the cfg->name can never accidentally be processed as a format string in the worker thread name. Signed-off-by: Kees Cook <keescook@chromium.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: rtl8821ae: fix not declared symbols should be static in sw.cKonrad Zapalowicz1-5/+5
This commit fixes the following sparse warnings: drivers/staging/rtl8821ae/rtl8821ae/sw.c: - 48:6: warning: symbol 'rtl8821ae_init_aspm_vars' was not declared. Should it be static? - 228:5: warning: symbol 'rtl8812ae_rx_command_packet_handler' was not declared. Should it be static? - 263:20: warning: symbol 'rtl8821ae_hal_ops' was not declared. Should it be static? - 314:23: warning: symbol 'rtl8821ae_mod_params' was not declared. Should it be static? - 321:20: warning: symbol 'rtl8821ae_hal_cfg' was not declared. Should it be static? All of this symbols are local, that is there are no references to them in the other files from this driver. Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: rtl8821ae: fix double const in sw.cKonrad Zapalowicz1-1/+1
This commit fixes the following sparse warning: drivers/staging/rtl8821ae/rtl8821ae/sw.c: - 449:14: warning: duplicate const Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: rtl8821ae: fix pointer coding styleLevente Kurusa1-1/+1
Found by checkpatch. Signed-off-by: Levente Kurusa <levex@linux.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: keucr: smilmain.c: cosmetic updatesTair Rzayev2-21/+17
* Move Check_D_MediaFmt() implementation up in smilmain.c to keep all the non-static functions at the top of the file; * Remove unnecessary extern and newlines from "init.h"; Signed-off-by: Tair Rzayev <tair.rzayev@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: comedi: addi_apci_1564: move apci1564_do_insn_bits() to ↵Chase Southwood2-17/+17
addi_apci_1564.c This function is already compliant with the comedi API and is behaving as comedi core expects. This patch moves it out of addi-data/hwdrv_apci1564.c and into the driver proper since no further work needs to be done on it. Signed-off-by: Chase Southwood <chase.southwood@gmail.com> Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: comedi: addi_apci_1564: move apci1564_di_insn_bits() to ↵Chase Southwood2-12/+12
addi_apci_1564.c This function is already compliant with the comedi API and is behaving as comedi core expects. This patch moves it out of addi-data/hwdrv_apci1564.c and into the driver proper since no further work needs to be done on it. Signed-off-by: Chase Southwood <chase.southwood@gmail.com> Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23Staging: comedi: fixed warning shown by checkpatch tool on cb_das16_cs.c fileRaghavendra Ganiga1-0/+1
This is a patch to fix the warnings shown by checkpatch tool on file cb_das16_cs.c Signed-off-by: Raghavendra Chandra Ganiga <ravi23ganiga@gmail.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23Staging: comedi: fixed warnings reported by checkpatch tool on comedi_test.c ↵Raghavendra Ganiga1-0/+2
file This is a patch to remove warnings reported by checkpatch tool on comedi_test.c file Signed-off-by: Raghavendra Chandra Ganiga <ravi23ganiga@gmail.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: comedi: Fixes Coding Style Warning in file das08.hSheetal Tigadoli1-1/+3
The Patch fixes following Warnings, found using checkpatch.pl, in file das08.h ./scripts/checkpatch.pl --file --terse drivers/staging/comedi/drivers/das08.h drivers/staging/comedi/drivers/das08.h:43: WARNING: line over 80 characters total: 0 errors, 1 warnings, 50 lines checked Signed-off-by: Sheetal Tigadoli <sheetal.tigadoli@gmail.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: comedi: ii_pci20kc: fix usage of uninit scalar in ii20k_attach()Christian Engelmayer1-0/+1
This driver supports the PCI-20001C-1a and PCI-20001C-2a carrier boards. The -2a version has 32 on-board DIO channels. In case this variant is detected, local variable 'has_dio' is set accordingly. Otherwise it is left uninitialized and the following subdevice instantiation depends on the stack. Detected by Coverity - CID 1077830. Signed-off-by: Christian Engelmayer <cengelma@gmx.at> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: comedi: addi_apci_1564: remove boardinfoChase Southwood1-12/+1
This driver only supports a single board type. Remove the boardinfo and its use in the driver. Signed-off-by: Chase Southwood <chase.southwood@gmail.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
generated by cgit v1.2.3 (git 2.39.0) at 2025-10-03 10:40:08 +0300