summaryrefslogtreecommitdiff
path: root/virt
diff options
context:
space:
mode:
authorJon Maloy <jon.maloy@ericsson.com>2017-11-02 17:44:15 +0300
committerDavid S. Miller <davem@davemloft.net>2017-11-03 09:48:46 +0300
commitfa36882682db0692ecbea20f859180f978923d72 (patch)
tree7c15eab8713880ac263c56e28a77087180f8e329 /virt
parent4bb1b116b7f37a64c08d28213a2e6f87fcef2d8b (diff)
downloadlinux-fa36882682db0692ecbea20f859180f978923d72.tar.xz
tipc: eliminate unnecessary probing
The neighbor monitor employs a threshold, default set to 32 peer nodes, where it activates the "Overlapping Neighbor Monitoring" algorithm. Below that threshold, monitoring is full-mesh, and no "domain records" are passed between the nodes. Because of this, a node never received a peer's ack that it has received the most recent update of the own domain. Hence, the field 'acked_gen' in struct tipc_monitor_state remains permamently at zero, whereas the own domain generation is incremented for each added or removed peer. This has the effect that the function tipc_mon_get_state() always sets the field 'probing' in struct tipc_monitor_state true, again leading the tipc_link_timeout() of the link in question to always send out a probe, even when link->silent_intv_count is zero. This is functionally harmless, but leads to some unncessary probing, which can easily be eliminated by setting the 'probing' field of the said struct correctly in such cases. At the same time, we explictly invalidate the sent domain records when the algorithm is not activated. This will eliminate any risk that an invalid domain record might be inadverently accepted by the peer. Signed-off-by: Jon Maloy <jon.maloy@ericsson.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'virt')
0 files changed, 0 insertions, 0 deletions