summaryrefslogtreecommitdiff
path: root/tools
diff options
context:
space:
mode:
authorDavide Caratti <dcaratti@redhat.com>2019-12-18 02:00:04 +0300
committerDavid S. Miller <davem@davemloft.net>2019-12-20 04:53:05 +0300
commit275c44aa194b7159d1191817b20e076f55f0e620 (patch)
treeec1b8335b428eee44534c96e0d36913d51d4d3f7 /tools
parent615f22f58029aa747b12768985e7f91cd053daa2 (diff)
downloadlinux-275c44aa194b7159d1191817b20e076f55f0e620.tar.xz
net/sched: cls_u32: fix refcount leak in the error path of u32_change()
when users replace cls_u32 filters with new ones having wrong parameters, so that u32_change() fails to validate them, the kernel doesn't roll-back correctly, and leaves semi-configured rules. Fix this in u32_walk(), avoiding a call to the walker function on filters that don't have a match rule connected. The side effect is, these "empty" filters are not even dumped when present; but that shouldn't be a problem as long as we are restoring the original behaviour, where semi-configured filters were not even added in the error path of u32_change(). Fixes: 6676d5e416ee ("net: sched: set dedicated tcf_walker flag when tp is empty") Signed-off-by: Davide Caratti <dcaratti@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'tools')
0 files changed, 0 insertions, 0 deletions