diff options
| author | Ingo Molnar <mingo@kernel.org> | 2018-04-27 12:54:40 +0300 | 
|---|---|---|
| committer | Ingo Molnar <mingo@kernel.org> | 2018-04-27 13:42:04 +0300 | 
| commit | 5f26c50143f58f256535bee8d93a105f36d4d2da (patch) | |
| tree | 5e6f0922ae95e352ea23aa6dda2a4ddc675ed815 /tools/perf/scripts/python/netdev-times.py | |
| parent | 0644f186fc9d77bb5bd198369e59fb28927a3692 (diff) | |
| download | linux-5f26c50143f58f256535bee8d93a105f36d4d2da.tar.xz | |
x86/bpf: Clean up non-standard comments, to make the code more readable
So by chance I looked into x86 assembly in arch/x86/net/bpf_jit_comp.c and
noticed the weird and inconsistent comment style it mistakenly learned from
the networking code:
 /* Multi-line comment ...
  * ... looks like this.
  */
Fix this to use the standard comment style specified in Documentation/CodingStyle
and used in arch/x86/ as well:
 /*
  * Multi-line comment ...
  * ... looks like this.
  */
Also, to quote Linus's ... more explicit views about this:
  http://article.gmane.org/gmane.linux.kernel.cryptoapi/21066
  > But no, the networking code picked *none* of the above sane formats.
  > Instead, it picked these two models that are just half-arsed
  > shit-for-brains:
  >
  >  (no)
  >      /* This is disgusting drug-induced
  >        * crap, and should die
  >        */
  >
  >   (no-no-no)
  >       /* This is also very nasty
  >        * and visually unbalanced */
  >
  > Please. The networking code actually has the *worst* possible comment
  > style. You can literally find that (no-no-no) style, which is just
  > really horribly disgusting and worse than the otherwise fairly similar
  > (d) in pretty much every way.
Also improve the comments and some other details while at it:
 - Don't mix same-line and previous-line comment style on otherwise
   identical code patterns within the same function,
 - capitalize 'BPF' and x86 register names consistently,
 - capitalize sentences consistently,
 - instead of 'x64' use 'x86-64': x64 is a Microsoft specific term,
 - use more consistent punctuation,
 - use standard coding style in macros as well,
 - fix typos and a few other minor details.
Consistent coding style is not optional, at least in arch/x86/.
No change in functionality.
( In case this commit causes conflicts with pending development code
  I'll be glad to help resolve any conflicts! )
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: David S. Miller <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>
Cc: Alexei Starovoitov <ast@fb.com>
Cc: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
Cc: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'tools/perf/scripts/python/netdev-times.py')
0 files changed, 0 insertions, 0 deletions
