diff options
| author | Chuck Lever <chuck.lever@oracle.com> | 2024-02-17 23:24:16 +0300 |
|---|---|---|
| committer | Christian Brauner <brauner@kernel.org> | 2024-02-21 11:34:26 +0300 |
| commit | 0e4a862174f2a8d1653a8a9cf0815020e1d3af24 (patch) | |
| tree | dd4d0a1647de2dc9bea821206c378a9afc242260 /tools/perf/builtin-kvm.c | |
| parent | f92e1a829d64dd66fa173c6934f03817d9e68d43 (diff) | |
| download | linux-0e4a862174f2a8d1653a8a9cf0815020e1d3af24.tar.xz | |
libfs: Convert simple directory offsets to use a Maple Tree
Test robot reports:
> kernel test robot noticed a -19.0% regression of aim9.disk_src.ops_per_sec on:
>
> commit: a2e459555c5f9da3e619b7e47a63f98574dc75f1 ("shmem: stable directory offsets")
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
Feng Tang further clarifies that:
> ... the new simple_offset_add()
> called by shmem_mknod() brings extra cost related with slab,
> specifically the 'radix_tree_node', which cause the regression.
Willy's analysis is that, over time, the test workload causes
xa_alloc_cyclic() to fragment the underlying SLAB cache.
This patch replaces the offset_ctx's xarray with a Maple Tree in the
hope that Maple Tree's dense node mode will handle this scenario
more scalably.
In addition, we can widen the simple directory offset maximum to
signed long (as loff_t is also signed).
Suggested-by: Matthew Wilcox <willy@infradead.org>
Reported-by: kernel test robot <oliver.sang@intel.com>
Closes: https://lore.kernel.org/oe-lkp/202309081306.3ecb3734-oliver.sang@intel.com
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Link: https://lore.kernel.org/r/170820145616.6328.12620992971699079156.stgit@91.116.238.104.host.secureserver.net
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Christian Brauner <brauner@kernel.org>
Diffstat (limited to 'tools/perf/builtin-kvm.c')
0 files changed, 0 insertions, 0 deletions